[SERVER-19986] clang-format.py lint fails in mci if files were deleted Created: 17/Aug/15 Updated: 21/Apr/17 Resolved: 04/Apr/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.13, 3.3.5 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Randolph Tan | Assignee: | Mark Benvenuto |
| Resolution: | Done | Votes: | 0 |
| Labels: | clang-format | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Requested: |
v3.2
|
||||||||||||
| Sprint: | Platforms 12 (04/01/16), Platforms 13 (04/22/16) | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
example failure:
|
| Comments |
| Comment by Githook User [ 21/Apr/17 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: (cherry picked from commit 264133830ecae413e451fac1ad3ef2a056c7a3d0) |
| Comment by Githook User [ 21/Apr/17 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: (cherry picked from commit 0c287324435952041423d03297248472080c8db3) |
| Comment by Githook User [ 21/Apr/17 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: (cherry picked from commit 462451181d36d499c6382745ca1e15eba1cd385c) |
| Comment by Githook User [ 21/Apr/17 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: (cherry picked from commit 2700f16594bfb76eb6af5c194bd9b764ad00b586) |
| Comment by Mark Benvenuto [ 21/Nov/16 ] |
|
It has not been backported. |
| Comment by Ian Whalen (Inactive) [ 19/Nov/16 ] |
|
mark.benvenuto do you know if this was ever backported to 3.2? |
| Comment by Max Hirschhorn [ 28/Jul/16 ] |
|
Requesting backport to the 3.2 branch because this bug can cause the lint task in Evergreen to pass in a patch build, but scons lint will fail when the changes are actually committed. This is because the clang_format.py script didn't pick up newly added files (i.e. files which are untracked by git). |
| Comment by Githook User [ 04/Apr/16 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: |
| Comment by Githook User [ 04/Apr/16 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: |
| Comment by Githook User [ 04/Apr/16 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: |
| Comment by Githook User [ 04/Apr/16 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: |
| Comment by Mark Benvenuto [ 17/Aug/15 ] |
|
Note that this is specifically for files deleted in an mci patch. It does not fail if the deleted files have been committed. |