[SERVER-19986] clang-format.py lint fails in mci if files were deleted Created: 17/Aug/15  Updated: 21/Apr/17  Resolved: 04/Apr/16

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 3.2.13, 3.3.5

Type: Bug Priority: Minor - P4
Reporter: Randolph Tan Assignee: Mark Benvenuto
Resolution: Done Votes: 0
Labels: clang-format
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Duplicate
is duplicated by SERVER-20850 clang-format patch build passed lint,... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v3.2
Sprint: Platforms 12 (04/01/16), Platforms 13 (04/22/16)
Participants:

 Description   

example failure:

 [2015/08/14 19:38:50.462] Exception in thread Thread-6:
 [2015/08/14 19:38:50.462] Traceback (most recent call last):
 [2015/08/14 19:38:50.462]   File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner
 [2015/08/14 19:38:50.462]     self.run()
 [2015/08/14 19:38:50.462]   File "/usr/lib64/python2.6/threading.py", line 484, in run
 [2015/08/14 19:38:50.462]     self.__target(*self.__args, **self.__kwargs)
 [2015/08/14 19:38:50.462]   File "/data/mci/src/buildscripts/clang_format.py", line 342, in worker
 [2015/08/14 19:38:50.462]     ret = func(item)
 [2015/08/14 19:38:50.462]   File "/data/mci/src/buildscripts/clang_format.py", line 281, in lint
 [2015/08/14 19:38:50.462]     with open(file_name, 'r') as original_text:
 [2015/08/14 19:38:50.462] IOError: [Errno 2] No such file or directory: '/data/mci/src/src/mongo/s/catalog/legacy/config_upgrade_v6_to_v7.cpp'



 Comments   
Comment by Githook User [ 21/Apr/17 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-19986 clang_format.py format fix

(cherry picked from commit 264133830ecae413e451fac1ad3ef2a056c7a3d0)
Branch: v3.2
https://github.com/mongodb/mongo/commit/df95d69472a02431fe299ea901ae5a5b789c41f5

Comment by Githook User [ 21/Apr/17 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-19986 clang_format.py lint-patch

(cherry picked from commit 0c287324435952041423d03297248472080c8db3)
Branch: v3.2
https://github.com/mongodb/mongo/commit/3e545c3e656e51dc71c04015fad15961099fd2be

Comment by Githook User [ 21/Apr/17 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-19986 clang_format.py format fix

(cherry picked from commit 462451181d36d499c6382745ca1e15eba1cd385c)
Branch: v3.2
https://github.com/mongodb/mongo/commit/b42e5752d27ff093e2fc269df85c1bf234e8dbe5

Comment by Githook User [ 21/Apr/17 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-19986 clang_format.py lint should enumerate all files for scons integration

(cherry picked from commit 2700f16594bfb76eb6af5c194bd9b764ad00b586)
Branch: v3.2
https://github.com/mongodb/mongo/commit/02b4e777ff69a31bfb6adba63a307b7e04b6916c

Comment by Mark Benvenuto [ 21/Nov/16 ]

It has not been backported.

Comment by Ian Whalen (Inactive) [ 19/Nov/16 ]

mark.benvenuto do you know if this was ever backported to 3.2?

Comment by Max Hirschhorn [ 28/Jul/16 ]

Requesting backport to the 3.2 branch because this bug can cause the lint task in Evergreen to pass in a patch build, but scons lint will fail when the changes are actually committed. This is because the clang_format.py script didn't pick up newly added files (i.e. files which are untracked by git).

Comment by Githook User [ 04/Apr/16 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-19986 clang_format.py format fix
Branch: master
https://github.com/mongodb/mongo/commit/264133830ecae413e451fac1ad3ef2a056c7a3d0

Comment by Githook User [ 04/Apr/16 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-19986 clang_format.py lint-patch
Branch: master
https://github.com/mongodb/mongo/commit/0c287324435952041423d03297248472080c8db3

Comment by Githook User [ 04/Apr/16 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-19986 clang_format.py format fix
Branch: master
https://github.com/mongodb/mongo/commit/462451181d36d499c6382745ca1e15eba1cd385c

Comment by Githook User [ 04/Apr/16 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-19986 clang_format.py lint should enumerate all files for scons integration
Branch: master
https://github.com/mongodb/mongo/commit/2700f16594bfb76eb6af5c194bd9b764ad00b586

Comment by Mark Benvenuto [ 17/Aug/15 ]

Note that this is specifically for files deleted in an mci patch. It does not fail if the deleted files have been committed.

Generated at Thu Feb 08 03:52:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.