[SERVER-20011] wrap calls to NetworkConnectionHook methods with std::terminate Created: 18/Aug/15 Updated: 19/Sep/15 Resolved: 21/Aug/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Networking |
| Affects Version/s: | None |
| Fix Version/s: | 3.1.8 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Adam Midvidy | Assignee: | Adam Midvidy |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Platform 8 08/28/15 |
| Participants: |
| Description |
|
The contract of the NetworkConnectionHook is that the NI is responsible for calling terminate if the hook throws. Now that all the hooks are implemented, we should add this check. The replication executor has a similar "makeNoexcept" utility, except it has the overhead of using stdx::function. As part of this work, we'll create a version templated on some function type, and then replace uses of makeNoexcept with it. |
| Comments |
| Comment by Githook User [ 21/Aug/15 ] |
|
Author: {u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}Message: |