[SERVER-20233] Custom move assignments need to handle self-move-assign on MSVC2013 Created: 31/Aug/15 Updated: 07/Oct/15 Resolved: 18/Sep/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.1.9 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mathias Stearn | Assignee: | Mathias Stearn |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Quint 9 09/18/15 |
| Participants: |
| Description |
|
MSVC2013's STL implementation can generate self-move-assignment. All of their types are safe, but we need to ensure that our types are. |
| Comments |
| Comment by Githook User [ 18/Sep/15 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: On MSVC2013 they must be no-ops. On other platforms they can leave the object |
| Comment by Eric Milkie [ 03/Sep/15 ] |
|
I'm not certain about resetting, but we could instead look at all of the warnings of this particular type, regardless of current disposition. |
| Comment by Andy Schwerin [ 03/Sep/15 ] |
|
milkie , can we reset the suppressed coverity warnings about this, and use coverity to find the problem? |