[SERVER-20233] Custom move assignments need to handle self-move-assign on MSVC2013 Created: 31/Aug/15  Updated: 07/Oct/15  Resolved: 18/Sep/15

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 3.1.9

Type: Task Priority: Major - P3
Reporter: Mathias Stearn Assignee: Mathias Stearn
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Quint 9 09/18/15
Participants:

 Description   

MSVC2013's STL implementation can generate self-move-assignment. All of their types are safe, but we need to ensure that our types are.



 Comments   
Comment by Githook User [ 18/Sep/15 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-20233 Custom move assignments must handle self-assignment

On MSVC2013 they must be no-ops. On other platforms they can leave the object
in a valid but unspecified state.
Branch: master
https://github.com/mongodb/mongo/commit/d38d401f6a11f20023aa2628723976fa993c16b6

Comment by Eric Milkie [ 03/Sep/15 ]

I'm not certain about resetting, but we could instead look at all of the warnings of this particular type, regardless of current disposition.

Comment by Andy Schwerin [ 03/Sep/15 ]

milkie , can we reset the suppressed coverity warnings about this, and use coverity to find the problem?

Generated at Thu Feb 08 03:53:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.