[SERVER-20238] Coverity analysis defect 73173: Logically dead code Created: 05/Aug/15  Updated: 13/Oct/15  Resolved: 01/Sep/15

Status: Closed
Project: Core Server
Component/s: Security
Affects Version/s: None
Fix Version/s: 3.1.8

Type: Improvement Priority: Major - P3
Reporter: Coverity Collector User Assignee: Andreas Nilsson
Resolution: Done Votes: 0
Labels: coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Security 9 (09/18/15)
Participants:

 Description   

Code can never be reached because of a logical contradiction

Defect 73173 (STATIC_C)
Checker DEADCODE (subcategory none)
File: /src/mongo/db/modules/enterprise/src/sasl/auxprop_mongodb_internal.cpp
Function mongo::<unnamed>::auxpropLookupMongoDBInternal(void *, sasl_server_params *, unsigned int, const char *, unsigned int)
/src/mongo/db/modules/enterprise/src/sasl/auxprop_mongodb_internal.cpp, line: 166
Assigning: "curRet" = "-20".

                curRet = SASL_NOUSER;

/src/mongo/db/modules/enterprise/src/sasl/auxprop_mongodb_internal.cpp, line: 182
At condition "curRet != -20", the value of "curRet" must be equal to -20.

            if (curRet != SASL_OK && curRet != SASL_NOUSER) {

/src/mongo/db/modules/enterprise/src/sasl/auxprop_mongodb_internal.cpp, line: 182
The condition "curRet != -20" cannot be true.

            if (curRet != SASL_OK && curRet != SASL_NOUSER) {

/src/mongo/db/modules/enterprise/src/sasl/auxprop_mongodb_internal.cpp, line: 183
Execution cannot reach this statement: "break;".

                break;



 Comments   
Comment by Githook User [ 13/Oct/15 ]

Author:

{u'username': u'agralius', u'name': u'Andreas Nilsson', u'email': u'andreas.nilsson@10gen.com'}

Message: SERVER-20238 Remove dead code from the auxprop plugin
Branch: artree
https://github.com/10gen/mongo-enterprise-modules/commit/c46ade6d88a5f71cbd4570f3b6b0b8ed0146b905

Comment by Githook User [ 01/Sep/15 ]

Author:

{u'username': u'agralius', u'name': u'Andreas Nilsson', u'email': u'andreas.nilsson@10gen.com'}

Message: SERVER-20238 Remove dead code from the auxprop plugin
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/c46ade6d88a5f71cbd4570f3b6b0b8ed0146b905

Generated at Thu Feb 08 03:53:36 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.