[SERVER-20331] Fix backup_restore.js test for RocksDB storage engine Created: 09/Sep/15  Updated: 07/Oct/15  Resolved: 25/Sep/15

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 3.1.9

Type: Bug Priority: Major - P3
Reporter: Igor Canadi Assignee: David Hows
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-20389 Fix backup_restore.js test performing... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

In backup_restore.js test, it's assumed that non-wiredtiger engine supports fsyncLock. RocksDB doesn't support fsyncLock, so can we please also add RocksDB to line 288: https://github.com/mongodb/mongo/blob/master/jstests/noPassthrough/backup_restore.js#L288



 Comments   
Comment by Igor Canadi [ 25/Sep/15 ]

Thanks David!

Comment by David Hows [ 25/Sep/15 ]

I've restructured this test somewhat.

The test will now check if the storage engine supports fsyncLock before performing a test.

There is still a further issue within this test, as I found it would fail at times when running the rolling rsync test under MMAPv1. This issue has been raised as SERVER-20389

This is an example run with rolling enabled under MMAP:
https://logkeeper.mongodb.org/build/56038afbbe07c4135f68e753/test/56038b21be07c4135f68e927

The following errors can be seen

[js_test:backup_restore] 2015-09-24T05:39:39.060+0000 d20021| 2015-09-24T05:39:38.899+0000 I -        [repl prefetch worker 13] Assertion: 10334:BSONObj size: -286331154 (0xEEEEEEEE) is invalid. Size must be between 0 and 16793600(16MB) First element: _id: ObjectId('56038c426e986b7e916e79fc')
[js_test:backup_restore] 2015-09-24T05:39:39.061+0000 d20021| 2015-09-24T05:39:38.899+0000 I -        [repl prefetch worker 7] Assertion: 10334:BSONObj size: -286331154 (0xEEEEEEEE) is invalid. Size must be between 0 and 16793600(16MB) First element: _id: ObjectId('56038c426e986b7e916e7b03')
[js_test:backup_restore] 2015-09-24T05:39:39.061+0000 d20021| 2015-09-24T05:39:38.900+0000 I -        [repl prefetch worker 8] Assertion: 10334:BSONObj size: -286331154 (0xEEEEEEEE) is invalid. Size must be between 0 and 16793600(16MB) First element: _id: ObjectId('56038c426e986b7e916e7be0')
[js_test:backup_restore] 2015-09-24T05:39:39.062+0000 d20021| 2015-09-24T05:39:38.900+0000 I -        [repl prefetch worker 9] Assertion: 10334:BSONObj size: -286331154 (0xEEEEEEEE) is invalid. Size must be between 0 and 16793600(16MB) First element: _id: ObjectId('56038c426e986b7e916e7c48')

Comment by David Hows [ 10/Sep/15 ]

Have added this to the commit for SERVER-18899.

Comment by Daniel Pasette (Inactive) [ 09/Sep/15 ]

David, can you address this as part of your work supporting fsyncLock with WT?

Generated at Thu Feb 08 03:53:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.