[SERVER-20436] NetworkInterfaceASIO Connection Pool races in shutdown with new requests Created: 16/Sep/15  Updated: 07/Oct/15  Resolved: 16/Sep/15

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: 3.1.8
Fix Version/s: 3.1.9

Type: Bug Priority: Major - P3
Reporter: Mira Carey Assignee: Mira Carey
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Platform 9 (09/18/15)
Participants:

 Description   

NetworkInterfaceASIO's connection pool can race in it's shutdown method with a new request, where the new request doesn't trigger a cancellation of the shutdown timer fast enough and we end up triggering one of the shutdown invariants (either pending requests or checked out connections)

We should guard against that and bail out if enter shutdown spuriously



 Comments   
Comment by Githook User [ 16/Sep/15 ]

Author:

{u'username': u'hanumantmk', u'name': u'Jason Carey', u'email': u'jcarey@argv.me'}

Message: SERVER-20436 correct updateState for NI ASIO ConnPool
Branch: master
https://github.com/mongodb/mongo/commit/eeb5452280d12e30c44fc1d8f0fc1d283b019ac8

Comment by Githook User [ 16/Sep/15 ]

Author:

{u'username': u'hanumantmk', u'name': u'Jason Carey', u'email': u'jcarey@argv.me'}

Message: Revert "SERVER-20436 more updateState for NI ASIO ConnPool"

This reverts commit 6bd10b12ce52ae01d5f5782e4fa6dacc31742c43.
Branch: master
https://github.com/mongodb/mongo/commit/e7fe0e33f2f8472c858251192770deafe6d05fef

Comment by Githook User [ 16/Sep/15 ]

Author:

{u'username': u'hanumantmk', u'name': u'Jason Carey', u'email': u'jcarey@argv.me'}

Message: SERVER-20436 more updateState for NI ASIO ConnPool

updateState needs to be called after every manipulation of the
checkedOut pool or the requests queue. Add in some missing invocations
Branch: master
https://github.com/mongodb/mongo/commit/6bd10b12ce52ae01d5f5782e4fa6dacc31742c43

Comment by Githook User [ 16/Sep/15 ]

Author:

{u'username': u'hanumantmk', u'name': u'Jason Carey', u'email': u'jcarey@argv.me'}

Message: SERVER-20436 NI ASIO ConnPool races in shutdown

NetworkInterfaceASIO's connection pool can race in it's shutdown method
with a new request, where the new request doesn't trigger a cancellation
of the shutdown timer fast enough and we end up triggering one of the
shutdown invariants (either pending requests or checked out connections)

We should guard against that and bail out if enter shutdown spuriously.
Branch: master
https://github.com/mongodb/mongo/commit/29f92ffe89fd0ca85aca2e43c52b43a7ea3d76d1

Generated at Thu Feb 08 03:54:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.