[SERVER-20504] Name aggregation operator for lookup: $lookup Created: 18/Sep/15 Updated: 28/Oct/15 Resolved: 23/Sep/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Aggregation Framework |
| Affects Version/s: | 3.1.8 |
| Fix Version/s: | 3.1.9 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kelly Stirman | Assignee: | Charlie Swanson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||
| Sprint: | QuInt A (10/12/15) | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
We should rename the $lookUp stage to be $lookup |
| Comments |
| Comment by Githook User [ 13/Oct/15 ] |
|
Author: {u'username': u'cswanson310', u'name': u'Charlie Swanson', u'email': u'charlie.swanson@mongodb.com'}Message: |
| Comment by Githook User [ 23/Sep/15 ] |
|
Author: {u'username': u'cswanson310', u'name': u'Charlie Swanson', u'email': u'charlie.swanson@mongodb.com'}Message: |
| Comment by Githook User [ 23/Sep/15 ] |
|
Author: {u'username': u'cswanson310', u'name': u'Charlie Swanson', u'email': u'charlie.swanson@mongodb.com'}Message: |
| Comment by Andy Schwerin [ 20/Sep/15 ] |
|
I'm fine with all lower case. I just think supporting both is needless hassle. |
| Comment by Kelly Stirman [ 20/Sep/15 ] |
|
@schwerin your reasoning for $lookUp seems logical and correct, but it also seems counterintuitive. If we use $lookUp many will mistakenly type $lookup, whereas if we use $lookup I don't imagine many will reason their way to mistakenly enter $lookUp. I do think we should use one in docs and examples - I was thinking the incorrect option could be "autocorrected" in a way, but had not considered outputs like explain and I'm guessing log files too. That makes me want to revise the request to be simply that the command should be $lookup instead of $lookUp. |
| Comment by Andy Schwerin [ 18/Sep/15 ] |
|
The aggregation operators are all verbs. The verb is "look up", while "lookup" is a noun. As such, I prefer that we name the operator "$lookUp". There is certainly precedence to use an all lower-case name for compound verbs that have single-word noun forms. The command "shutdown" should really be named "shutDown" by my reasoning, and it is not. I do not think we should support both, however. We should choose one and stick to it. The output of "explain" isn't going to know which case you supplied, and so it will not match, the documentation should really be consistent anyhow, etc. |