[SERVER-20569] Remove "ok" fields from replication structs Created: 22/Sep/15 Updated: 06/Dec/22 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Scott Hernandez (Inactive) | Assignee: | Backlog - Replication Team |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Replication
|
| Participants: |
| Description |
|
Returning "ok" fields from structs/args classes like ReplSetRequestVotesArgs, which was fixed already, can cause problems.
These classes should not parse, nor emit the "ok" field used for command responses (since the command response will not replace it). |
| Comments |
| Comment by Andy Schwerin [ 23/Sep/15 ] |
|
I have a recollection that ReplSetHeartbeatResponse is weird and special. In particular, sometimes ok: 0 responses contain data other than an error code and message, or at least they used to, and mongod depended on that data. I dislike that behavior, but anyone making changes will need to be aware of it. |