[SERVER-20778] Bring comment and code in signalDrainComplete into agreement Created: 06/Oct/15  Updated: 15/Oct/15  Resolved: 13/Oct/15

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: 3.1.8
Fix Version/s: 3.2.0-rc0

Type: Bug Priority: Major - P3
Reporter: Andy Schwerin Assignee: Matt Dannenberg
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl B (10/30/15)
Participants:

 Description   

The comment describing the implementation of signalDrainComplete in ReplicationCoordinatorImpl does not match the implementation below it, particularly with regards to when the global exclusive lock is dropped. Either the comment or the code must be incorrect, and should be fixed.



 Comments   
Comment by Githook User [ 13/Oct/15 ]

Author:

{u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}

Message: SERVER-20778 make signalDrainComplete comment align with signalDrainComplete code
Branch: master
https://github.com/mongodb/mongo/commit/65afa27bd884f852a5ee8ae3e7174d1f648ae4a1

Comment by Eric Milkie [ 06/Oct/15 ]

I believe the comment was left incorrect as of 197ea2a625dc04d95a7ad4933283b5f02ca2ad9e (SERVER-18584). The comment should be corrected to match the code behavior, which I believe is the desirable behavior.

Generated at Thu Feb 08 03:55:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.