[SERVER-20810] Find command errors should not include a stack trace Created: 07/Oct/15 Updated: 15/Oct/15 Resolved: 09/Oct/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying, Shell |
| Affects Version/s: | 3.1.9 |
| Fix Version/s: | 3.2.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andy Schwerin | Assignee: | David Storch |
| Resolution: | Done | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | QuInt A (10/12/15) |
| Participants: |
| Description |
|
Here is an example command an error in the 3.1.9 shell when it is configured to use find command:
And here is what you get with the 3.0.6 shell or the 3.1.9 shell with wire protocol find:
|
| Comments |
| Comment by Githook User [ 09/Oct/15 ] | |||||||||||||||
|
Author: {u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}Message: | |||||||||||||||
| Comment by Andy Schwerin [ 09/Oct/15 ] | |||||||||||||||
|
Checkout _getErrorWithCode(codeOrObj, message) used by doassert. It's got a pretty weird signature, but shows how asserts generate instances of Error. | |||||||||||||||
| Comment by Andy Schwerin [ 09/Oct/15 ] | |||||||||||||||
|
No, the purpose was to get rid of the stack trace. On Fri, Oct 9, 2015, 12:32 AM Max Hirschhorn (JIRA) <jira@mongodb.org> | |||||||||||||||
| Comment by Githook User [ 09/Oct/15 ] | |||||||||||||||
|
Author: {u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}Message: Revert " This reverts commit 1b7f8319e1115bdaca3ad48c986846065db13569. | |||||||||||||||
| Comment by Max Hirschhorn [ 09/Oct/15 ] | |||||||||||||||
|
The jstests/sharding/replset_config/bad_config_load.js test depends on the presence of a "code" property on the Error object.
If this ticket is meant to undo the work of
| |||||||||||||||
| Comment by Githook User [ 08/Oct/15 ] | |||||||||||||||
|
Author: {u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}Message: |