[SERVER-20850] clang-format patch build passed lint, but had an error that broke the build Created: 09/Oct/15 Updated: 14/Apr/16 Resolved: 04/Apr/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Tools |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Geert Bosch | Assignee: | DO NOT USE - Backlog - Platform Team |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | clang-format | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Participants: | |||||||||
| Description |
|
The patch at https://evergreen.mongodb.com/build/mongodb_mongo_master_linux_64_77b5a7cd3d8f95c411549c1342b6fb696e352adc_15_10_08_19_37_01 My commit to fix it shows the exact formatting error that wasn't detected: commit 177e91b765ae7b966bd17a0eadf80635b0417023 diff --git a/src/mongo/dbtests/validate_tests.cpp b/src/mongo/dbtests/validate_tests.cpp ASSERT_FALSE(checkValid()); |
| Comments |
| Comment by Mark Benvenuto [ 12/Oct/15 ] |
|
The issue is that clang-format.py gets the list of files to use from git via ls-files, and git-apply run by MCI does not add the file into the index. https://github.com/mongodb/mongo/blob/master/buildscripts/clang_format.py#L473 |