[SERVER-20882] remove the verify() macro Created: 12/Oct/15 Updated: 06/Dec/22 Resolved: 13/Jul/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Adam Midvidy | Assignee: | DO NOT USE - Backlog - Dev Tools |
| Resolution: | Duplicate | Votes: | 2 |
| Labels: | platforms-re-triaged | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Assigned Teams: |
Developer Tools
|
||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
The verify() macro is poorly designed because it throws an exception in release builds, and crashes in debug builds. In practice we can end up hitting verify()s at runtime fairly frequently, as indicated by jstestfuzz. As part of the 3.3 cycle we should remove the verify macro completely, replacing uses of it with invariant() or uassert() as appropriate. |
| Comments |
| Comment by Max Hirschhorn [ 13/Jul/18 ] |
|
acm, should this ticket be closed as a duplicate of SERVER-6317? |