[SERVER-20949] ClusterClientCursorParams should not be passed by value Created: 15/Oct/15  Updated: 04/Nov/15  Resolved: 30/Oct/15

Status: Closed
Project: Core Server
Component/s: Querying, Sharding
Affects Version/s: None
Fix Version/s: 3.2.0-rc2

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: David Storch
Resolution: Done Votes: 0
Labels: coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-20948 Coverity analysis defect 76593: Big p... Closed
is duplicated by SERVER-20950 Coverity analysis defect 76591: Big p... Closed
is duplicated by SERVER-20951 Coverity analysis defect 76590: Big p... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: QuInt B (11/02/15)
Participants:

 Description   

A large function call parameter or exception catch statement is passed by value

Defect 76592 (STATIC_C)
Checker PASS_BY_VALUE (subcategory none)
File: /src/mongo/s/query/async_results_merger.cpp
Function mongo::AsyncResultsMerger::AsyncResultsMerger(mongo::executor::TaskExecutor *, mongo::ClusterClientCursorParams)
/src/mongo/s/query/async_results_merger.cpp, line: 66
Passing parameter params of type "mongo::ClusterClientCursorParams" (size 160 bytes) by value.

                                           ClusterClientCursorParams params)



 Comments   
Comment by Githook User [ 30/Oct/15 ]

Author:

{u'username': u'dstorch', u'name': u'David Storch', u'email': u'david.storch@10gen.com'}

Message: SERVER-20949 thread params object to AsyncResultsMerger by rvalue reference
Branch: master
https://github.com/mongodb/mongo/commit/79aa65b0f2abbb965dda5d516d0ffe52f15abd02

Generated at Thu Feb 08 03:55:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.