[SERVER-21072] optimize rpc::readRequestMetadata Created: 22/Oct/15  Updated: 27/Oct/15  Resolved: 23/Oct/15

Status: Closed
Project: Core Server
Component/s: Internal Code, Networking
Affects Version/s: None
Fix Version/s: 3.2.0-rc1

Type: Task Priority: Major - P3
Reporter: Adam Midvidy Assignee: Adam Midvidy
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-20609 Performance Regression from 3.0.6 for... Closed
Backwards Compatibility: Fully Compatible
Sprint: Platform B (10/30/15)
Participants:

 Description   

rpc::readRequestMetadata currently has some inefficiencies, such as scanning the same BSON object 3 times and allocating ErrorInfos on the empty-metadata path. As this is hot code (on the command path) it should be optimized.

As part of this work, the format of ServerSelectionMetadata on the wire will change. Instead of having $readPreference and $secondaryOk be top-level fields of the metadata object, they will be sub-objects of a top-level $ssm object. As such this work needs to get in to rc1, given that we need to support rolling upgrade from rc1 to rc2 (but not rc0 to rc1).



 Comments   
Comment by Githook User [ 23/Oct/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-21072 optimize rpc::readRequestMetadata
Branch: master
https://github.com/mongodb/mongo/commit/3e1d9d183f9e5f184de23bde145962cd86812c68

Generated at Thu Feb 08 03:56:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.