[SERVER-21208] "server up" check in perf.yml is in the wrong place Created: 29/Oct/15 Updated: 17/Nov/15 Resolved: 04/Nov/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Performance |
| Affects Version/s: | None |
| Fix Version/s: | 3.0.8, 3.2.0-rc3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Michael O'Brien | Assignee: | David Daly |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Backport Completed: | |
| Sprint: | Performance C (11/20/15) |
| Participants: |
| Description |
|
https://github.com/mongodb/mongo/blob/a4b34582b6fd71785f8be653409293788476f03f/etc/perf.yml#L59-L61 that line of the script needs to be done in a separate command. as written, it is useless because it runs in a command with "background: true" so it won't actually block the next command in the task. |
| Comments |
| Comment by Githook User [ 16/Nov/15 ] |
|
Author: {u'username': u'dalyd', u'name': u'dalyd', u'email': u'david.daly@mongodb.com'}Message: (cherry picked from commit e29401fe31d95322d7b2ab58dfc94ce04f27d5a1) |
| Comment by Githook User [ 04/Nov/15 ] |
|
Author: {u'username': u'dalyd', u'name': u'dalyd', u'email': u'david.daly@mongodb.com'}Message: |
| Comment by Michael O'Brien [ 02/Nov/15 ] |
|
Yup, that fix sounds appropriate. |
| Comment by David Daly [ 02/Nov/15 ] |
|
I propose adding another entry to function, and moving the sleep and the check to that entry. mpobrien does that look like it would fix it? |