[SERVER-21225] Better error messaging when attempting to add a shard with the same name or members as an existing shard Created: 30/Oct/15 Updated: 16/May/16 Resolved: 10/May/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.3.6 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Dianna Hohensee (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Sharding 10 (02/19/16), Sharding 11 (03/11/16), Sharding 12 (04/01/16), Sharding 13 (04/22/16), Sharding 14 (05/13/16) |
| Participants: |
| Description |
|
Currently when you try to add a shard with the same name as an existing shard you get a duplicate key error, and if you try to add a shard with the same host(s) as an existing shard you get a not master error
|
| Comments |
| Comment by Githook User [ 10/May/16 ] | |||||||||||||||||||||||||||||||||||
|
Author: {u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}Message: | |||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 07/Apr/16 ] | |||||||||||||||||||||||||||||||||||
|
Author: {u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}Message: Revert " This reverts commit 6178203a1cfecd6a9fe3af68e2bab73544d486d7. | |||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 06/Apr/16 ] | |||||||||||||||||||||||||||||||||||
|
Author: {u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}Message: | |||||||||||||||||||||||||||||||||||
| Comment by Spencer Brody (Inactive) [ 07/Mar/16 ] | |||||||||||||||||||||||||||||||||||
|
I would reword the first message slightly to something like "Replica set <replset name> is already a part of the cluster as shard <shard name>" - the user probably doesn't know anything about the 'shards' collection, the key point is that it's already a shard. As for the second message, can we actually tell the user that the problem is that the host is already a part of another shard, rather than saying we can't contact it? | |||||||||||||||||||||||||||||||||||
| Comment by Dianna Hohensee (Inactive) [ 07/Mar/16 ] | |||||||||||||||||||||||||||||||||||
|
Spencer, is this update satisfactory?
|