[SERVER-21286] versionArray not computed correctly from git-describe Created: 04/Nov/15  Updated: 17/Nov/15  Resolved: 12/Nov/15

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 3.2.0-rc3

Type: Bug Priority: Major - P3
Reporter: Ramon Fernandez Marina Assignee: Jonathan Reams
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-17329 Improve management of server version ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Build B (10/30/15), Build C (11/20/15)
Participants:

 Description   

Below is a stand-alone python script with the code from SConscript that generates version information for version.cpp.in:

#!/usr/bin/python
 
import re
import sys
 
VER = sys.argv[1]
 
version_parts = [ x for x in re.match(r'^(\d+)\.(\d+)\.(\d+)-?((?:(rc)(\d+))?.*)?', VER).groups() ]
version_extra = version_parts[3] if version_parts[3] else ""
 
if version_parts[4] == 'rc':
    version_parts[3] = int(version_parts[5]) + -50
elif version_parts[3]:
    version_parts[3] = -100
else:
    version_parts[3] = 0
version_array = [ int(x) for x in version_parts[:4]]
 
print version_array

It produces the following output:

$ ./ver.py 3.3.1
[3, 3, 1, 0]
$ ./ver.py 3.3.1-1-abcd
[3, 3, 1, -100]

This indicates that 3.3.1 is newer than the first commit after 3.3.1, which is wrong.



 Comments   
Comment by Githook User [ 12/Nov/15 ]

Author:

{u'username': u'jbreams', u'name': u'Jonathan Reams', u'email': u'jbreams@mongodb.com'}

Message: SERVER-21286 Bump release number if version string is pre-release
Branch: master
https://github.com/mongodb/mongo/commit/457246ef9b013b30cafa4bb45125dc2e4193d6c2

Generated at Thu Feb 08 03:56:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.