[SERVER-21317] Better fallback for builds with no version.json and no git repo Created: 05/Nov/15 Updated: 18/Apr/18 Resolved: 31/Mar/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.20, 3.4.15, 3.5.6 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Ramon Fernandez Marina | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Done | Votes: | 1 |
| Labels: | bkp | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v3.4, v3.2
|
||||||||||||
| Sprint: | Platforms 2017-04-17 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
In SConstruct:479 we try to extract version information using "git describe" when version.json is not present in the repo (which is the new default, see Since there may be users building without a git repo it would be nice to add another fallback, such as environment variable or some other mechanism. Workarounds include:
|
| Comments |
| Comment by Githook User [ 18/Apr/18 ] |
|
Author: {'email': 'acm@mongodb.com', 'name': 'Andrew Morrow', 'username': 'acmorrow'}Message: (cherry picked from commit 19b7e7213746e50323abe8ec97bb33023965aab7) |
| Comment by Githook User [ 18/Apr/18 ] |
|
Author: {'email': 'acm@mongodb.com', 'name': 'Andrew Morrow', 'username': 'acmorrow'}Message: (cherry picked from commit 19b7e7213746e50323abe8ec97bb33023965aab7) |
| Comment by yuandeqiao [X] [ 18/May/17 ] |
|
thanks sir, I'll try it later....... |
| Comment by Andrew Morrow (Inactive) [ 17/May/17 ] |
|
yuan.Mr - I think you have placed the version.json file in the wrong directory. It doesn't go in etc, just at the top level of the source tree. Note that on the branch you are using, 3.0, there is no enforcement of the format of the values. On the master branch, there is, as of commit https://github.com/mongodb/mongo/commit/19b7e7213746e50323abe8ec97bb33023965aab7. |
| Comment by yuandeqiao [X] [ 17/May/17 ] |
|
hello,i adding a fake mongo-3.0.11/etc/version.json file before compiling that looks as follows: Checking for C library pcap... no can you tell me why? thank ! |
| Comment by Githook User [ 31/Mar/17 ] |
|
Author: {u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}Message: |
| Comment by Jonathan Reams [ 19/Nov/15 ] |
|
Because there are workarounds, I'm bumping this into 3.3 desired. |