[SERVER-21458] NetworkInterfaceASIO should time out if NetworkConnectionHook request hangs past deadline passed to startCommand Created: 13/Nov/15  Updated: 25/Nov/15  Resolved: 19/Nov/15

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: None
Fix Version/s: 3.2.0-rc4

Type: Bug Priority: Major - P3
Reporter: Adam Midvidy Assignee: Adam Midvidy
Resolution: Done Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Platform D (12/11/15)
Participants:

 Comments   
Comment by Githook User [ 19/Nov/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-21458 thread request timeout in to ConnectionPool::get in NetworkInterfaceASIO
Branch: master
https://github.com/mongodb/mongo/commit/a6221d1dba72923083af809efb5cd61625d7eee2

Comment by Adam Midvidy [ 18/Nov/15 ]

I misdiagnosed this issue earlier. It seems like if the NetworkConnectionHook's command hangs, we do not actually time out the request. Moving in to rc4 as this could cause bad behavior in the event of a network partition.

Comment by Spencer Brody (Inactive) [ 18/Nov/15 ]

For the record, we had to add this line to work around this issue in sharding.

Comment by Adam Midvidy [ 16/Nov/15 ]

moving out of rc4 since it isn't clear this is needed - the higher level timeout passed to startCommand should be sufficient to ensure that we always time out - we shouldn't be using RemoteCommandRequest::kNoTimeout.

Generated at Thu Feb 08 03:57:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.