[SERVER-21473] Coverity analysis defect 21944: Division or modulo by zero Created: 16/Nov/15  Updated: 05/Feb/16  Resolved: 12/Jan/16

Status: Closed
Project: Core Server
Component/s: Performance, Shell
Affects Version/s: None
Fix Version/s: 3.3.1

Type: Bug Priority: Minor - P4
Reporter: Coverity Collector User Assignee: David Daly
Resolution: Done Votes: 0
Labels: coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Performance F (02/01/16)
Participants:

 Description   

Division or modulo by zero results in undefined behavior.

Defect 21944 (STATIC_C)
Checker DIVIDE_BY_ZERO (subcategory none)
File: /src/mongo/scripting/bson_template_evaluator.cpp
Function mongo::BsonTemplateEvaluator::evalSeqInt(mongo::BsonTemplateEvaluator*, const char *, const mongo::BSONObj &, mongo::BSONObjBuilder &)
/src/mongo/scripting/bson_template_evaluator.cpp, line: 240
Assigning: "modval" = "spec[mongo::StringData("mod")].numberInt()". The value of "modval" is now 0.

            int modval = spec["mod"].numberInt();

/src/mongo/scripting/bson_template_evaluator.cpp, line: 241
In expression "curr_seqval % modval", modulo by expression "modval" which may be zero has undefined behavior.

            curr_seqval = (curr_seqval % modval);



 Comments   
Comment by Githook User [ 12/Jan/16 ]

Author:

{u'username': u'dalyd', u'name': u'dalyd', u'email': u'david.daly@mongodb.com'}

Message: SERVER-21473: Coverity analysis defect 21944: Division or modulo by zero
Branch: master
https://github.com/mongodb/mongo/commit/148f36e82e0c0194159c47d7bfd3add0bd7192b1

Comment by Eric Milkie [ 16/Nov/15 ]

Accessible via benchrun only; can only crash the shell, from what I can tell.

Generated at Thu Feb 08 03:57:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.