[SERVER-21492] Remove key-file permissions code for JS tests from the top-level SConstruct Created: 17/Nov/15  Updated: 28/Aug/23  Resolved: 28/Aug/23

Status: Closed
Project: Core Server
Component/s: Build, Testing Infrastructure
Affects Version/s: 3.2.0-rc2
Fix Version/s: None

Type: Task Priority: Minor - P4
Reporter: Kamran K. Assignee: [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
Resolution: Won't Do Votes: 0
Labels: tig-resmoke
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-20873 Keyfile permissions are changed using... Closed
Assigned Teams:
Server Development Platform
Participants:

 Description   

The top-level SConstruct is setting permissions of 600 on jstests/libs/key1 and jstests/libs/key2.

This is problematic because a) it's not obvious that running scons has this side effect and b) it can cause test failures if you run JS tests from a tree that hasn't run any earlier scons commands.

Credit to max.hirschhorn for noticing this as part of SERVER-20873.



 Comments   
Comment by Brooke Miller [ 19/Nov/21 ]

We're re-assigning this to SDP to re-evaluate this as part of the self-testable installs project.

Comment by Andrew Morrow (Inactive) [ 03/Oct/18 ]

FYI the hygienic builds project is another angle on this, since if these key files are installed from the git tree to the self-testable-install, then they can be appropriately chmodded then.

Comment by Max Hirschhorn [ 02/Oct/18 ]

resmoke.py never uses the jstests/libs/key1 or jstests/libs/key2, and therefore has never responsible for running os.chmod() on them unlike how it does so for other --keyFile and --encryptionKeyFile command line options. If we migrate this logic from the SConstruct to resmoke.py, then we can also remove its equivalent in the bypass_compile_and_fetch_binaries.py script.

Generated at Thu Feb 08 03:57:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.