[SERVER-21525] Coverity analysis defect 76757: Redundant test Created: 18/Nov/15  Updated: 18/Nov/15  Resolved: 18/Nov/15

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: Kaloian Manassiev
Resolution: Done Votes: 0
Labels: coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

Test always evaluates the same

Defect 76757 (STATIC_C)
Checker DEADCODE (subcategory redundant_test)
File: /src/mongo/s/catalog/replset/replset_dist_lock_manager.cpp
Function mongo::ReplSetDistLockManager::lock(mongo::OperationContext *, mongo::StringData, mongo::StringData, std::chrono::duration<long, std::ratio<(long)1, (long)1000>>, std::chrono::duration<long, std::ratio<(long)1, (long)1000>>)
/src/mongo/s/catalog/replset/replset_dist_lock_manager.cpp, line: 311
At condition "networkErrorRetries < 2", the value of "networkErrorRetries" must be equal to 0.

                networkErrorRetries < kMaxNumLockAcquireRetries) {

/src/mongo/s/catalog/replset/replset_dist_lock_manager.cpp, line: 282
Assigning: "networkErrorRetries" = "0".

            int networkErrorRetries = 0;

/src/mongo/s/catalog/replset/replset_dist_lock_manager.cpp, line: 310
The condition "networkErrorRetries < 2" must be true.

            if (ShardRegistry::kAllRetriableErrors.count(status.code()) &&



 Comments   
Comment by Eric Milkie [ 18/Nov/15 ]

Kal already fixed this.

Generated at Thu Feb 08 03:57:36 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.