[SERVER-21630] Expand resmoke's CheckReplDBHash support to config servers and sharded replica sets Created: 23/Nov/15  Updated: 06/Apr/18  Resolved: 18/Jan/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.4.15, 3.6.3, 3.7.2

Type: Task Priority: Major - P3
Reporter: Kamran K. Assignee: Kevin Albertson
Resolution: Done Votes: 0
Labels: tig-dataconsistency
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Duplicate
is duplicated by SERVER-33498 ReplSetTest.checkReplicaSet fails whe... Closed
Problem/Incident
causes SERVER-33068 run_check_repl_dbhash.js hook exits w... Closed
Related
related to SERVER-25640 Have ReplSetTest run checkDBHashes() ... Closed
related to SERVER-34352 Run dbhash check before collection va... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.6, v3.4
Sprint: TIG 13 (04/22/16), TIG 2018-1-1, TIG 2017-12-18, TIG 2018-1-29
Participants:
Linked BF Score: 0

 Description   

It'd be nice if the CheckReplDBHash resmoke hook supported sharded replica sets and config servers for further consistency checks in test suites.



 Comments   
Comment by Githook User [ 25/Mar/18 ]

Author:

{'email': 'kevin.albertson@10gen.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}

Message: SERVER-21630 run CheckReplDBHash on csrs and shard replset

And run ValidateCollections hook on priority=0 secondaries.

(cherry picked from commit b9decc492c0ff942d5bcd6e8c799de70fa0839af)
Branch: v3.4
https://github.com/mongodb/mongo/commit/92e92c023843c2f73ce752284a14fa1e3ca92933

Comment by Githook User [ 11/Feb/18 ]

Author:

{'email': 'kevin.albertson@10gen.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}

Message: SERVER-21630 run CheckReplDBHash on csrs and shard replset

And run ValidateCollections hook on priority=0 secondaries.

(cherry picked from commit b9decc492c0ff942d5bcd6e8c799de70fa0839af)
Branch: v3.6
https://github.com/mongodb/mongo/commit/ba709552e7792ae53aeb7a22752ab9c65e717fc1

Comment by Githook User [ 17/Jan/18 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs'}

Message: SERVER-21630 run CheckReplDBHash on csrs and shard replset

And run ValidateCollections hook on priority=0 secondaries.
Branch: master
https://github.com/mongodb/mongo/commit/b9decc492c0ff942d5bcd6e8c799de70fa0839af

Comment by Max Hirschhorn [ 10/Jan/18 ]

I've reverted the changes from 43b1a29 and am re-opening this ticket because they've caused the CheckReplDBHash hook to become a no-op. I discovered this issue by inspection after noticing of certain log messages from ReplSetTest while auditing my changes from SERVER-32474.

The run_check_repl_dbhash.js file was changed to use the "hosts" field from the server's isMaster response to match the changes from 79da41f to the run_validate_collections.js file as part of SERVER-31128. However, nodes with priority=0—how resmoke.py configures secondaries unless all_nodes_electable=true)—are actually returned via the "passives" field in the server's isMaster response. The connections array should be updated to handle both the "hosts" and "passives" fields.

Note: This also means that the changes from SERVER-31128 aren't working as intended because we'll skip over secondaries with priority=0. It should be updated accordingly as part of this ticket.

Comment by Githook User [ 10/Jan/18 ]

Author:

{'email': 'max.hirschhorn@mongodb.com', 'name': 'Max Hirschhorn', 'username': 'visemet'}

Message: Revert "SERVER-21630 run CheckReplDBHash on csrs and shard replset"

This reverts commit 43b1a2984a4c7b9d1fbc9e4d0d6596c6f626ffda.
Branch: master
https://github.com/mongodb/mongo/commit/12fe88d24a821d4411b5e7ca5973293d10e707b4

Comment by Githook User [ 26/Dec/17 ]

Author:

{'username': 'kevinAlbs', 'name': 'Kevin Albertson', 'email': 'kevin.albertson@10gen.com'}

Message: SERVER-21630 run CheckReplDBHash on csrs and shard replset
Branch: master
https://github.com/mongodb/mongo/commit/43b1a2984a4c7b9d1fbc9e4d0d6596c6f626ffda

Comment by Githook User [ 21/Dec/17 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs'}

Message: Revert "SERVER-21630 run CheckReplDBHash on csrs and shard replset"

This reverts commit 117ccba5b73070c98789c1066cf4b31597e878da.
Branch: master
https://github.com/mongodb/mongo/commit/eac8109597710f910fa788875b4bd9d0b28060c5

Comment by Githook User [ 21/Dec/17 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs'}

Message: SERVER-21630 run CheckReplDBHash on csrs and shard replset
Branch: master
https://github.com/mongodb/mongo/commit/117ccba5b73070c98789c1066cf4b31597e878da

Comment by Andy Schwerin [ 30/Nov/17 ]

Depends on the specific consistency checks desired, but I bet you could start doing some interesting ones.

Comment by Andy Schwerin [ 23/Nov/15 ]

This might require the ability to do consistent secondary reads.

Generated at Thu Feb 08 03:57:56 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.