[SERVER-21679] Unit test the storage engines begin/endBackup functions Created: 26/Nov/15  Updated: 14/Apr/16  Resolved: 23/Mar/16

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: David Hows Assignee: David Hows
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Backwards Compatibility: Fully Compatible
Participants:
Linked BF Score: 0

 Description   

Currently, we have no direct testing of the beginBackup and endBackup functionality of each storage engine.

These tests would only cover the actions taken by any implementation of a storage engines itself when receiving the beginBackup function call from the StorageEngine API.

As there is protection in the StorageEngine API to prevent multiple subsequent calls to the beginBackup API the behaviour of multiple calls in the storage engine layer is undefined and untested.

We should add unit tests which cover the following correct behaviour is displayed by each implementation of an engine within MongoDB:

  • That the API returns OK status to beginBackup followed by endBackup
  • That the API causes MongoDB to hit a MONGO_UNREACHABLE when endBackup is called when the API does not provide backup functionality.


 Comments   
Comment by David Hows [ 14/Mar/16 ]

alexander.gorrod, yes. There has been some back and forth recently, but this is currently waiting.

Comment by David Hows [ 07/Dec/15 ]

Have added further definition into what is to be tested.

Comment by Scott Hernandez (Inactive) [ 26/Nov/15 ]

How do you actually test the calls do what is expected? Please define "responds correctly" a bit more in your description – so there is a clear definition of what is being tested.

Generated at Thu Feb 08 03:58:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.