[SERVER-21692] MozJSImplscope must immediately check the return value of JS_NewRuntime Created: 30/Nov/15 Updated: 01/Dec/15 Resolved: 30/Nov/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | JavaScript |
| Affects Version/s: | 3.2.0-rc4 |
| Fix Version/s: | 3.2.0-rc5 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Mira Carey | Assignee: | Mira Carey |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Platform D (12/11/15) |
| Participants: |
| Description |
|
After some code motion, we're failing to check the return value of JS_NewRuntime until after several functions are called on it. This can lead to null pointer dereferences. |
| Comments |
| Comment by Githook User [ 30/Nov/15 ] |
|
Author: {u'username': u'hanumantmk', u'name': u'Jason Carey', u'email': u'jcarey@argv.me'}Message: Moved an uassert away from a call site. Opens up the chance for nullptr |