[SERVER-21994] cleanup_orphaned_basic.js Created: 18/Dec/15  Updated: 18/Nov/16  Resolved: 28/Jan/16

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.2.0
Fix Version/s: 3.2.5, 3.3.2

Type: Bug Priority: Major - P3
Reporter: Adam Midvidy Assignee: Misha Tyulenev
Resolution: Done Votes: 0
Labels: test-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Completed:
Participants:
Linked BF Score: 0

 Description   

sharding failed on linux-64-duroff

cleanup_orphaned_basic.js - Logs | History

BF Ticket Generated by adam.midvidy



 Comments   
Comment by Githook User [ 10/Mar/16 ]

Author:

{u'username': u'mikety', u'name': u'Misha Tyulenev', u'email': u'misha@mongodb.com'}

Message: BF-1493 add namespace check to cleanupOrphaned

(cherry picked from commit df8e729bf9866081b670a4622140756542e09cc1)
Branch: v3.2
https://github.com/mongodb/mongo/commit/2d82529d71be07cbccea58aa8d459a7e8f64b1f0

Comment by Misha Tyulenev [ 04/Jan/16 ]

ian.whalen seems that the issue is different: This fails at the unsharded collection not a bad namespace as the original BF ticket.

assert.commandFailed(shardAdmin.runCommand(

{cleanupOrphaned: ns}

));

[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.824+0000 assert: command worked when it should have failed: { "ok" : 1 } : undefined
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.824+0000 doassert@src/mongo/shell/assert.js:15:14
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.824+0000 assert.commandFailed@src/mongo/shell/assert.js:250:5
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.824+0000 @jstests/sharding/cleanup_orphaned_basic.js:60:1
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.824+0000 @jstests/sharding/cleanup_orphaned_basic.js:6:2
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.824+0000 
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.825+0000 2016-01-04T17:53:38.820+0000 E QUERY    [thread1] Error: command worked when it should have failed: { "ok" : 1 } : undefined :
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.825+0000 doassert@src/mongo/shell/assert.js:15:14
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.825+0000 assert.commandFailed@src/mongo/shell/assert.js:250:5
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.825+0000 @jstests/sharding/cleanup_orphaned_basic.js:60:1
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.825+0000 @jstests/sharding/cleanup_orphaned_basic.js:6:2
[js_test:cleanup_orphaned_basic] 2016-01-04T17:53:38.825+0000 

Comment by Ian Whalen (Inactive) [ 04/Jan/16 ]

misha.tyulenev we just saw a similar failure happen again on master here: sharding on solaris

Can you please investigate if this problem is ongoing? if it's actually a different problem, just let me know and I'll open a new issue to track.

Comment by Misha Tyulenev [ 22/Dec/15 ]

Need to backport to 3.2

Comment by Githook User [ 21/Dec/15 ]

Author:

{u'username': u'mikety', u'name': u'Misha Tyulenev', u'email': u'misha@mongodb.com'}

Message: BF-1493 add namespace check to cleanupOrphaned
Branch: master
https://github.com/mongodb/mongo/commit/df8e729bf9866081b670a4622140756542e09cc1

Comment by Misha Tyulenev [ 18/Dec/15 ]

Agreed

Comment by Kaloian Manassiev [ 18/Dec/15 ]

Misha, I had looked at this a little bit before and I think the problem is that the command itself doesn't check for validity of the namespace, but we rely on it happening later in the call chain:

[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.293-0500 d21261| 2015-12-17T19:13:17.287-0500 I SHARDING [conn12] remotely refreshing metadata for  \/."*<>:|?, current shard version is 0|0||000000000000000000000000, current metadata version is 0|0||000000000000000000000000
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 d21261| 2015-12-17T19:13:17.291-0500 I SHARDING [conn12] metadata of collection  \/."*<>:|? already up to date (shard version : 0|0||000000000000000000000000, took 4ms)
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 assert: command worked when it should have failed: { "ok" : 1 } : undefined
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 d21261| 2015-12-17T19:13:17.292-0500 W COMMAND  [conn12] skipping orphaned data cleanup for  \/."*<>:|?, collection is not sharded

I think the fix would be to first find out where does the check for invalid namespace happen in the cases where the test succeeds and then to add a check within the cleanupOrphaned command itself.

Comment by Daniel Pasette (Inactive) [ 18/Dec/15 ]

I think misha recently added this test, which may make it easier for him to diagnose.

Comment by Adam Midvidy [ 18/Dec/15 ]

[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 assert: command worked when it should have failed: { "ok" : 1 } : undefined
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 d21261| 2015-12-17T19:13:17.292-0500 W COMMAND  [conn12] skipping orphaned data cleanup for  \/."*<>:|?, collection is not sharded
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 doassert@src/mongo/shell/assert.js:15:14
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 assert.commandFailed@src/mongo/shell/assert.js:274:5
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 @jstests/sharding/cleanup_orphaned_basic.js:53:1
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 @jstests/sharding/cleanup_orphaned_basic.js:6:2
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.294-0500 
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.295-0500 2015-12-17T19:13:17.292-0500 E QUERY    [thread1] Error: command worked when it should have failed: { "ok" : 1 } : undefined :
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.295-0500 doassert@src/mongo/shell/assert.js:15:14
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.295-0500 assert.commandFailed@src/mongo/shell/assert.js:274:5
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.295-0500 @jstests/sharding/cleanup_orphaned_basic.js:53:1
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.295-0500 @jstests/sharding/cleanup_orphaned_basic.js:6:2
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.296-0500 
[js_test:cleanup_orphaned_basic] 2015-12-17T19:13:17.296-0500 failed to load: jstests/sharding/cleanup_orphaned_basic.js

Comment by Adam Midvidy [ 18/Dec/15 ]

kaloian.manassiev can you please triage?

Generated at Thu Feb 08 03:59:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.