[SERVER-22052] Refactor deleteDocument, pass document directly as parameter Created: 04/Jan/16  Updated: 06/Dec/22

Status: Backlog
Project: Core Server
Component/s: Sharding, Storage
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Backlog - Query Execution
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Assigned Teams:
Query Execution
Backwards Compatibility: Fully Compatible
Sprint: Sharding E (01/08/16)
Participants:
Linked BF Score: 0

 Description   

Collection::deleteDocument currently takes a RecordId value as parameter, and then queries the collection for the actual document. However, many of the callers of the method already have the document, as well as the location. Instead of just passing in the record location and redundantly looking up the document from memory, pass the document directly into the method as well and save an extra disk call.



 Comments   
Comment by Githook User [ 07/Jan/16 ]

Author:

{u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}

Message: Revert "SERVER-22052 refactor Collection::deleteDocument to pass in the to-be-deleted document directly as a parameter."

This reverts commit 3b29ba46f2d7ce938ea0f084b2d0cb46d46c651e.
Branch: master
https://github.com/mongodb/mongo/commit/1e764d28b0c2436f1d22c128d2e7676de4dcd103

Comment by Githook User [ 05/Jan/16 ]

Author:

{u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}

Message: SERVER-22052 refactor Collection::deleteDocument to pass in the to-be-deleted document directly as a parameter.
Branch: master
https://github.com/mongodb/mongo/commit/3b29ba46f2d7ce938ea0f084b2d0cb46d46c651e

Generated at Thu Feb 08 03:59:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.