[SERVER-22052] Refactor deleteDocument, pass document directly as parameter Created: 04/Jan/16 Updated: 06/Dec/22 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | Sharding, Storage |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Backlog - Query Execution |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Assigned Teams: |
Query Execution
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Sprint: | Sharding E (01/08/16) | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
Collection::deleteDocument currently takes a RecordId value as parameter, and then queries the collection for the actual document. However, many of the callers of the method already have the document, as well as the location. Instead of just passing in the record location and redundantly looking up the document from memory, pass the document directly into the method as well and save an extra disk call. |
| Comments |
| Comment by Githook User [ 07/Jan/16 ] |
|
Author: {u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}Message: Revert "SERVER-22052 refactor Collection::deleteDocument to pass in the to-be-deleted document directly as a parameter." This reverts commit 3b29ba46f2d7ce938ea0f084b2d0cb46d46c651e. |
| Comment by Githook User [ 05/Jan/16 ] |
|
Author: {u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}Message: SERVER-22052 refactor Collection::deleteDocument to pass in the to-be-deleted document directly as a parameter. |