[SERVER-22341] Fix JS lint errors in jstests/ with ESLint --fix Created: 28/Jan/16  Updated: 18/Nov/16  Resolved: 09/Feb/16

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.2.4, 3.3.2

Type: Task Priority: Major - P3
Reporter: Kamran K. Assignee: Michael Grundy
Resolution: Done Votes: 0
Labels: test-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-22468 Format JS code with approved style in... Closed
Backwards Compatibility: Fully Compatible
Backport Completed:
Sprint: TIG 10 (02/19/16)
Participants:

 Description   

ESLint can automatically fix some linting errors with --fix. We should fix the following categories of errors to make our JavaScript work better with token-based formatters like clang-format:

  1. no-extra-semi
  2. semi

To make it easier to review the changes and parallelize work, this task will be scoped to the JS in jstests/.



 Comments   
Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in v3.2 that weren't in master with eslint --fix
Branch: v3.2
https://github.com/mongodb/mongo/commit/2501e87819f0f69ffd87381d3777ffed21e54c38

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/aggregation with eslint --fix

(cherry picked from commit bca7050e6f207a8cec2423bc1a5f3a0645bb1cac)
Branch: v3.2
https://github.com/mongodb/mongo/commit/5496c3d1178e8acec4983a4fe1196a4c369d1e1e

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/auth with eslint --fix

(cherry picked from commit c070452eed7d4dc7be2ebff083e0830d3d486896)
Branch: v3.2
https://github.com/mongodb/mongo/commit/96b3134c5e287b20acd6ebd03b897753db14c908

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/concurrency with eslint --fix

(cherry picked from commit 424abb4cf3dc680e2acc56ebed96f47949c79c71)
Branch: v3.2
https://github.com/mongodb/mongo/commit/67c12eba34e8f245bf2777aec32d5dc67a955160

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/disk with eslint --fix

(cherry picked from commit bdeb6bf698b693cf774a9b5e8e810f815fbaf144)
Branch: v3.2
https://github.com/mongodb/mongo/commit/4e63ace8fd730e45fce839f577a48d05c7afed76

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/dur with eslint --fix

(cherry picked from commit 4bbb7bae4d29e88fcf988aed856f2be4d6fc2439)
Branch: v3.2
https://github.com/mongodb/mongo/commit/644bb55e1855c4f098928563a12408cad5a9bf35

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/gle with eslint --fix

(cherry picked from commit a0997b39c6033dbd1df2f9e32018361fcc25e392)
Branch: v3.2
https://github.com/mongodb/mongo/commit/1af223e89c16d2942b3e5807bfe08d43b37476a2

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/httpinterface with eslint --fix

(cherry picked from commit b56e96fdb89aa9f036901b9653bf900595c1956a)
Branch: v3.2
https://github.com/mongodb/mongo/commit/2c7dffcc8d6cd6a427433553ac6bbfd7dba26fa0

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/libs with eslint --fix

(cherry picked from commit 4fff5009ab22466f8780ce727b9fbf1992f0db62)
Branch: v3.2
https://github.com/mongodb/mongo/commit/9957b0c1e2f26eeb284592ecd3a0f8bed648e2f2

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/mmap_v1 with eslint --fix

(cherry picked from commit a3be230c5af98b8ca149cb89544345654a2ca7d1)
Branch: v3.2
https://github.com/mongodb/mongo/commit/fe833db2b5524039a97f0e118d9f4387b65bdf56

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/multiVersion with eslint --fix

(cherry picked from commit 2689df80fa1a476b26d02937456d34191feb1087)
Branch: v3.2
https://github.com/mongodb/mongo/commit/ca999596b6ea45d68eee5f498a7b56cadf9d1050

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/noPassthrough with eslint --fix

(cherry picked from commit b4b016d9732a189fceddbcad5be378a7848d95b1)

Conflicts:
jstests/noPassthrough/count_helper_read_preference.js
jstests/noPassthrough/exit_logging.js
Branch: v3.2
https://github.com/mongodb/mongo/commit/622c2df3b2b69a7649a7e45f201e8a03719977a2

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/noPassthroughWithMongod with eslint --fix

(cherry picked from commit 8ca7124defb9a617281e4e557fd811c66ee0ef82)
Branch: v3.2
https://github.com/mongodb/mongo/commit/ad078fb9aa7ed6102059006cc722739699fe6f03

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/perf with eslint --fix

(cherry picked from commit 899b96b6983e3b16631cf449f63a993cd2d9a8fe)
Branch: v3.2
https://github.com/mongodb/mongo/commit/07d7b4520943ff3e6fd2f7221b944e8ce6669878

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/repl with eslint --fix

(cherry picked from commit bb207e87bbf6593cc73be1e4f684f3e83191ff61)
Branch: v3.2
https://github.com/mongodb/mongo/commit/96a28e9f7b3b8687535419e8a9e0817ffa88e4e8

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/replsets with eslint --fix

(cherry picked from commit f768da59c3c4bbee218355e2c9c7bdd1df266ff4)
Branch: v3.2
https://github.com/mongodb/mongo/commit/f58b7bf88e4e3885c3c9ebb88f798f6af182cbb4

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/slow1 with eslint --fix

(cherry picked from commit c86e2cdec27d7fe90dc8e3f056adff2848dd1839)
Branch: v3.2
https://github.com/mongodb/mongo/commit/b09ac1bf86e695ffcf9e79aff0be8fe744c44222

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/slow2 with eslint --fix

(cherry picked from commit f48ed9956e605bfe9816cbaf045652d8e003897e)
Branch: v3.2
https://github.com/mongodb/mongo/commit/53664abc64361d65edf5713366a752ad6892bb05

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/ssl with eslint --fix

(cherry picked from commit 56aa683f83f8bda0a4e0f09566034f12f9a4d4d7)
Branch: v3.2
https://github.com/mongodb/mongo/commit/08c1c6fc8f1c0f999cb996b5750060bd27b01692

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/sslSpecial with eslint --fix

(cherry picked from commit f541080e8a4283a79cf21c5d62ffac325f7dad05)
Branch: v3.2
https://github.com/mongodb/mongo/commit/17047e522f97da1a551f7b0f99788b953f662f5e

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/tool with eslint --fix

(cherry picked from commit 55b5ad87239ba35e542add1e7402fe775dc19b8e)
Branch: v3.2
https://github.com/mongodb/mongo/commit/a599b754f111500fdb73e3ab613625a67274c1ad

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/parallel with eslint --fix

Conflicts:
jstests/parallel/manyclients.js

(cherry picked from commit 6bf0dcee8a4027d98ef307b267121352fed070c4)
Branch: v3.2
https://github.com/mongodb/mongo/commit/968189756e79653cbd4336670dc42afc60e24813

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/core with eslint --fix

(cherry picked from commit 3bed8596d18275d1561e4f44f1f0bd72c1e038f1)

Conflicts:
jstests/core/geo_update_btree2.js
jstests/core/update_min_max_examples.js
jstests/core/update_mul_examples.js
Branch: v3.2
https://github.com/mongodb/mongo/commit/a86f395f51280f36d96217cbd593784fb2327196

Comment by Githook User [ 17/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/sharding with eslint --fix

(cherry picked from commit fb46f0112723f46d31b04c84aeb8aa6a3b08aa1f)

Conflicts:
jstests/sharding/bulk_insert.js
jstests/sharding/coll_epoch_test0.js
jstests/sharding/coll_epoch_test1.js
jstests/sharding/coll_epoch_test2.js
jstests/sharding/migration_with_source_ops.js
jstests/sharding/mongos_no_detect_sharding.js
jstests/sharding/remove2.js
Branch: v3.2
https://github.com/mongodb/mongo/commit/f068a5843808618d8cdf300a37b3ff9c69bba934

Comment by Githook User [ 09/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/multiVersion/minor_version* with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/2e4ca677b4b9f776a791b0f8e8c767d5e694bab4

Comment by Githook User [ 09/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/sharding with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/fb46f0112723f46d31b04c84aeb8aa6a3b08aa1f

Comment by Githook User [ 09/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/core with eslint --fix

Conflicts:
jstests/core/count_hint.js
Branch: master
https://github.com/mongodb/mongo/commit/3bed8596d18275d1561e4f44f1f0bd72c1e038f1

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/parallel with eslint --fix

Conflicts:
jstests/parallel/manyclients.js
Branch: master
https://github.com/mongodb/mongo/commit/6bf0dcee8a4027d98ef307b267121352fed070c4

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/tool with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/55b5ad87239ba35e542add1e7402fe775dc19b8e

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/sslSpecial with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/f541080e8a4283a79cf21c5d62ffac325f7dad05

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/ssl with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/56aa683f83f8bda0a4e0f09566034f12f9a4d4d7

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/slow2 with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/f48ed9956e605bfe9816cbaf045652d8e003897e

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/slow1 with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/c86e2cdec27d7fe90dc8e3f056adff2848dd1839

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/replsets with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/f768da59c3c4bbee218355e2c9c7bdd1df266ff4

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/repl with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/bb207e87bbf6593cc73be1e4f684f3e83191ff61

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/readonly with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/a4d52e4c8505d15b58a465720edca4a2906fd23f

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/perf with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/899b96b6983e3b16631cf449f63a993cd2d9a8fe

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/noPassthroughWithMongod with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/8ca7124defb9a617281e4e557fd811c66ee0ef82

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/noPassthrough with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/b4b016d9732a189fceddbcad5be378a7848d95b1

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/multiVersion with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/2689df80fa1a476b26d02937456d34191feb1087

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/mmap_v1 with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/a3be230c5af98b8ca149cb89544345654a2ca7d1

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/libs with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/4fff5009ab22466f8780ce727b9fbf1992f0db62

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/httpinterface with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/b56e96fdb89aa9f036901b9653bf900595c1956a

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/gle with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/a0997b39c6033dbd1df2f9e32018361fcc25e392

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/dur with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/4bbb7bae4d29e88fcf988aed856f2be4d6fc2439

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/disk with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/bdeb6bf698b693cf774a9b5e8e810f815fbaf144

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/concurrency with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/424abb4cf3dc680e2acc56ebed96f47949c79c71

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/auth with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/c070452eed7d4dc7be2ebff083e0830d3d486896

Comment by Githook User [ 05/Feb/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-22341 fix jslint errors in jstests/aggregation with eslint --fix
Branch: master
https://github.com/mongodb/mongo/commit/bca7050e6f207a8cec2423bc1a5f3a0645bb1cac

Generated at Thu Feb 08 04:00:07 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.