[SERVER-22343] Use scons --mute to make compile logs readable Created: 12/Feb/14 Updated: 15/Mar/16 Resolved: 15/Mar/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Logging |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Siyuan Zhou | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Platforms 12 (04/01/16) | ||||||||
| Participants: | |||||||||
| Description |
|
Quoting SCons: It isn't that bad!:
Example output:
|
| Comments |
| Comment by Andrew Morrow (Inactive) [ 20/Feb/16 ] | ||||||||||||||||||||||||
|
However, what Andy mentioned above about GetBuildFailures and atexit has been on my personal todo list for some time. I think it is something worth doing anyway. But I still don't think we should mute the build line. I really do sometimes need to see what flags were used on a given build even if there were no failures. | ||||||||||||||||||||||||
| Comment by Andy Schwerin [ 12/Feb/14 ] | ||||||||||||||||||||||||
|
See Section 9.4 of the SCons User Guide for one option. In essence, you could use python's atexit.register to register an exit handler that used the SCons GetBuildFailures method to enumerate the build failures. From those, you could print the command lines that failed. Here's a not-for-commit example, that you can stick at the end of the SConstruct today:
| ||||||||||||||||||||||||
| Comment by Michael O'Brien [ 12/Feb/14 ] | ||||||||||||||||||||||||
|
It looks like it doesn't show the whole command on error.
with mute:
If there's a change you can make to scons options to make it show the whole command line on error, we can push this change - otherwise i'll close this as works as designed. | ||||||||||||||||||||||||
| Comment by Andy Schwerin [ 12/Feb/14 ] | ||||||||||||||||||||||||
|
Actually, I'm interested enough in this that I'm going to take a quick peek at our options in SCons for this. | ||||||||||||||||||||||||
| Comment by Andy Schwerin [ 12/Feb/14 ] | ||||||||||||||||||||||||
|
Thumbs down unless you can make SCons print the whole executed command line on error. If you can do that, then double thumbs up. | ||||||||||||||||||||||||
| Comment by Michael O'Brien [ 12/Feb/14 ] | ||||||||||||||||||||||||
| Comment by Ian Whalen (Inactive) [ 12/Feb/14 ] | ||||||||||||||||||||||||
|
need to get confirmation from Eric or Andy before making this change. | ||||||||||||||||||||||||
| Comment by Michael O'Brien [ 12/Feb/14 ] | ||||||||||||||||||||||||
|
Makes sense to me. Is there any drawback to doing this? Any potentially information in the long compile lines that we are giving up by doing this? |