[SERVER-22378] Remove sync parameter from StorageEngine::flushAllFiles() Created: 29/Jan/16  Updated: 06/Dec/22  Resolved: 07/Nov/16

Status: Closed
Project: Core Server
Component/s: MMAPv1, Storage, WiredTiger
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Kyle Suarez Assignee: Backlog - Storage Execution Team
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-22271 Invalid use of MS_ASYNC in msync() call Closed
Assigned Teams:
Storage Execution
Sprint: Integration F (02/01/16), Integration 10 (02/22/16), Integration 11 (03/14/16)
Participants:

 Description   

StorageEngine::flushAllFiles() takes a boolean parameter, sync, which performs synchronous flushing when true and asynchronous flushing when false. However,

  • MMAPv1 on Windows cannot support asynchronous flushing, and using MS_ASYNC in Posix is a no-op (see SERVER-22271).
  • WiredTiger and the other KVEngine-based storage engines all ignore the sync parameter, doing the flush synchronously.
  • RocksDB also ignores the sync parameter.

As a consequence, there is no longer a need to keep the sync parameter.


Generated at Thu Feb 08 04:00:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.