[SERVER-22437] Coverity analysis defect 77704: Redundant test Created: 02/Feb/16  Updated: 23/Nov/16  Resolved: 05/Feb/16

Status: Closed
Project: Core Server
Component/s: WiredTiger
Affects Version/s: None
Fix Version/s: 3.2.4, 3.3.2

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: Michael Cahill (Inactive)
Resolution: Done Votes: 0
Labels: code-only, coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Completed:
Participants:

 Description   

Test always evaluates the same

Defect 77704 (STATIC_C)
Checker DEADCODE (subcategory redundant_test)
File: /src/third_party/wiredtiger/src/schema/schema_create.c
Function __create_index
/src/third_party/wiredtiger/src/schema/schema_create.c, line: 553
At condition "exists", the value of "exists" must be equal to 0.

    	if (!exists)

/src/third_party/wiredtiger/src/schema/schema_create.c, line: 403
Assigning: "exists" = "have_extractor = false".

    	exists = have_extractor = false;

/src/third_party/wiredtiger/src/schema/schema_create.c, line: 553
The condition "!exists" must be true.

    	if (!exists)



 Comments   
Comment by Githook User [ 24/Feb/16 ]

Author:

{u'name': u'Ramon Fernandez', u'email': u'ramon@mongodb.com'}

Message: Import wiredtiger-wiredtiger-2.7.0-650-g5cdd3e3.tar.gz from wiredtiger branch mongodb-3.2

ref: 07966a4..5cdd3e3

SERVER-22437 Coverity analysis defect 77704: Redundant test
SERVER-22438 Coverity analysis defect 77705: Dereference before null check
SERVER-22676 WiredTiger fails to open databases created by 3.0.0 or 3.0.1
WT-2130 Improve on-disk page utlilization with random workloads
WT-2215 WT_LSN needs to support atomic reads and updates
WT-2295 WT_SESSION.create does a full-scan of the main table
WT-2352 Allow build and test without requiring lz4
WT-2356 log scan advances to next log file on partially written record
WT-2363 Remove built in support for bzip2
WT-2368 row-store can pass garbage keys to collator functions
WT-2369 Use C compiler to detect headers instead of C++ compiler
WT-2371 parent split cannot access the page after page-index swap
WT-2372 WiredTiger windows builder fails with C4005 against the "inline" macro
WT-2377 WTPERF doesn't compile in Windows under MSVC
WT-2378 Tasks time out on LSM builder
WT-2397 Cursor traversal from end of the tree skips records.
WT-60 Big endian port
Branch: v3.2
https://github.com/mongodb/mongo/commit/f77630a9e971cae1f921292ea31d9d40a4b096b8

Comment by Githook User [ 18/Feb/16 ]

Author:

{u'username': u'ddanderson', u'name': u'Don Anderson', u'email': u'dda@mongodb.com'}

Message: Merge pull request #2477 from wiredtiger/server-22437

SERVER-22437 Remove dead code from WT-2295.
Branch: mongodb-3.2
https://github.com/wiredtiger/wiredtiger/commit/32bb3fc49574b20f7a965036fd588b93ae87e9ec

Comment by Githook User [ 18/Feb/16 ]

Author:

{u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

Message: SERVER-22437 Remove dead code from WT-2295.
Branch: mongodb-3.2
https://github.com/wiredtiger/wiredtiger/commit/202429294b7d0883c4847f2bcb43808079503a77

Comment by Githook User [ 11/Feb/16 ]

Author:

{u'username': u'ddanderson', u'name': u'Don Anderson', u'email': u'dda@mongodb.com'}

Message: Merge pull request #2477 from wiredtiger/server-22437

SERVER-22437 Remove dead code from WT-2295.
Branch: mongodb-3.2
https://github.com/wiredtiger/wiredtiger/commit/32bb3fc49574b20f7a965036fd588b93ae87e9ec

Comment by Githook User [ 11/Feb/16 ]

Author:

{u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

Message: SERVER-22437 Remove dead code from WT-2295.
Branch: mongodb-3.2
https://github.com/wiredtiger/wiredtiger/commit/202429294b7d0883c4847f2bcb43808079503a77

Comment by Githook User [ 04/Feb/16 ]

Author:

{u'username': u'agorrod', u'name': u'Alex Gorrod', u'email': u'alexg@wiredtiger.com'}

Message: Import wiredtiger-wiredtiger-2.7.0-592-gcc96d99.tar.gz from wiredtiger branch mongodb-3.4

ref: 7fea169..cc96d99

WT-60 Big endian port
WT-2130 Improve on-disk page utlilization with random workloads
WT-2215 WT_LSN needs to support atomic reads and updates
WT-2295 WT_SESSION.create does a full-scan of the main table
WT-2352 Allow build and test without requiring lz4
WT-2356 Log scan advances to next log file on partially written record
WT-2363 Remove built in support for bzip2
WT-2368 Row-store can pass garbage keys to collator functions
WT-2369 Use C compiler to detect headers instead of C++ compiler
WT-2371 Parent split cannot access the page after page-index swap
WT-2372 WiredTiger windows builder fails with C4005 against the "inline" macro
WT-2377 WTPERF doesn't compile in Windows under MSVC
WT-2378 Tasks time out on LSM builder
SERVER-22388 WiredTiger changes for MongoDB 3.3.2
SERVER-22437 Coverity analysis defect 77704: Redundant test
SERVER-22438 Coverity analysis defect 77705: Dereference before null check
Branch: master
https://github.com/mongodb/mongo/commit/79a378bddf664714190dc9d0a34b1d8cd4951588

Comment by Githook User [ 03/Feb/16 ]

Author:

{u'username': u'ddanderson', u'name': u'Don Anderson', u'email': u'dda@mongodb.com'}

Message: Merge pull request #2477 from wiredtiger/server-22437

SERVER-22437 Remove dead code from WT-2295.
Branch: develop
https://github.com/wiredtiger/wiredtiger/commit/32bb3fc49574b20f7a965036fd588b93ae87e9ec

Comment by Githook User [ 03/Feb/16 ]

Author:

{u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

Message: SERVER-22437 Remove dead code from WT-2295.
Branch: develop
https://github.com/wiredtiger/wiredtiger/commit/202429294b7d0883c4847f2bcb43808079503a77

Generated at Thu Feb 08 04:00:24 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.