[SERVER-22512] Remove unnecessary startBalancer() and stopBalancer() calls in JS tests Created: 08/Feb/16  Updated: 06/Dec/22  Resolved: 07/Jul/16

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: [DO NOT USE] Backlog - Sharding Team
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Sharding
Operating System: ALL
Sprint: Sharding 10 (02/19/16), Sharding 11 (03/11/16)
Participants:

 Description   

Many JS tests call stopBalancer() unnecessarily because ShardingTest does it by default now. Also check that startBalancer() is not called when it could be instead specified in the ShardingTest using the enableBalancer parameter.

This fix is important because writes to the config db do not yet support any retries, and the sharding_csrs_continuous_config_stepdown suite must blacklist tests that do not currently support command retries. Removing unnecessary writes keeps some tests in the suite.



 Comments   
Comment by Githook User [ 20/Sep/17 ]

Author:

{'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}

Message: SERVER-22512 Remove unnecessary calls to stopBalancer

Modified some to work in v3.2 – e.g. removed getShardPrimary which doesn't exist in v3.2

(cherry picked from commit 2477b8c33b2e8f26fcde47c38c19c3fbb8b99839)
Branch: v3.2
https://github.com/mongodb/mongo/commit/41798bb7ecfa6d5d491f02f9dba68681da486355

Comment by Andy Schwerin [ 07/Jul/16 ]

We're doing this piecemeal as we go.

Comment by Githook User [ 09/Jun/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-22512 Remove unnecessary calls to stopBalancer
Branch: master
https://github.com/mongodb/mongo/commit/2477b8c33b2e8f26fcde47c38c19c3fbb8b99839

Generated at Thu Feb 08 04:00:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.