[SERVER-22514] multiversion suite no longer needs to use writeMode:legacy Created: 08/Feb/16 Updated: 14/Apr/16 Resolved: 14/Mar/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 3.3.4 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Esha Maharishi (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Sharding 12 (04/01/16) | ||||||||
| Participants: | |||||||||
| Description |
|
The multiversion suite still uses writeMode:legacy for compatibility with servers that don't support write commands, but we no longer test (on the master branch) any servers that old. We should be using the commands-based write mode in the multiversion suite. |
| Comments |
| Comment by Githook User [ 14/Mar/16 ] | |||||||||||||
|
Author: {u'name': u'Esha Maharishi', u'email': u'esha.maharishi@mongodb.com'}Message: | |||||||||||||
| Comment by Kamran K. [ 14/Mar/16 ] | |||||||||||||
|
esha.maharishi, mixed_storage_version_replication.js has an assertion that assumes legacy writes. Try applying this additional patch:
| |||||||||||||
| Comment by Esha Maharishi (Inactive) [ 14/Mar/16 ] | |||||||||||||
|
It seems like the multiversion suite now uses 3.2 and master? Just a quick update, I tried a patch with this change since it's required for https://evergreen.mongodb.com/version/56e2fd3c3ff1220156001654_0 | |||||||||||||
| Comment by Spencer Brody (Inactive) [ 10/Feb/16 ] | |||||||||||||
|
kamran.khan, presumably there's no need for those tests and they could be deleted from master, as they would continue to exist in the 3.2 and 3.0 branches? | |||||||||||||
| Comment by Kamran K. [ 10/Feb/16 ] | |||||||||||||
|
The multiversion suite still uses 2.6 and 3.0 binaries. | |||||||||||||
| Comment by David Storch [ 08/Feb/16 ] | |||||||||||||
|
kamran.khan, nope, that seems like a reasonable change. I think we should default to testing "commands" unless we need specific "legacy" coverage. The same holds for readMode. Question: does the multiVersion suite still test nodes of version 3.0 or earlier on the master branch? If not, then we can also start using readMode "commands". | |||||||||||||
| Comment by Kamran K. [ 08/Feb/16 ] | |||||||||||||
|
david.storch, any concerns with this proposed change from a query perspective? |