[SERVER-22899] Remove 'requires_persistence' tag, replace with logic using server status Created: 29/Feb/16  Updated: 06/Dec/22  Resolved: 10/Mar/16

Status: Closed
Project: Core Server
Component/s: Storage, Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Charlie Swanson Assignee: Backlog - Storage Execution Team
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-21414 Add information to server status to t... Closed
Assigned Teams:
Storage Execution
Participants:

 Description   

Once SERVER-21414 is resolved, we won't need the 'requires_persistence' tag. Tests can instead do something like this check, possibly adding a helper like this one. This may allow us to salvage parts of tests that do not require persistence.



 Comments   
Comment by Andy Schwerin [ 10/Mar/16 ]

Then I suggest we close this "works as designed".

Comment by Kamran K. [ 09/Mar/16 ]

I think we should go with tags for clarity.

Comment by Andy Schwerin [ 01/Mar/16 ]

I have a preference for tags because they expose information about the test
in a structured way.

On Mon, Feb 29, 2016, 5:30 PM Charlie Swanson (JIRA) <jira@mongodb.org>

Comment by Charlie Swanson [ 29/Feb/16 ]

That's a valid point. I think we should at least be consistent. Maybe this is more of a decision for our test infrastructure team, but IMO we should always use tags or never use them. Today, there are some tests that appear to have run, but print out a message saying that they in fact did not run. For example, SERVER-22148 touched a lot of read committed tests that have this behavior. Then there are the the tests mentioned here which are excluded by tag. We should decide which is preferred and morph this ticket into the work to make them consistent.

My preference would be to use tags, but I may be biased.

cc kamran.khan

Comment by Andy Schwerin [ 29/Feb/16 ]

Do you propose that we remove the tag even for tests that cannot run at all without persistence? Such tests will then appear to "pass" when in fact they've done nothing, which might be misleading.

Generated at Thu Feb 08 04:01:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.