[SERVER-23067] Final round of JS linting and formatting Created: 10/Mar/16  Updated: 18/Nov/16  Resolved: 18/Mar/16

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 3.2.5, 3.3.4

Type: Task Priority: Major - P3
Reporter: Kamran K. Assignee: Michael Grundy
Resolution: Done Votes: 0
Labels: test-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-22338 Integrate JavaScript linting into sco... Closed
Backwards Compatibility: Fully Compatible
Backport Completed:
Sprint: TIG 12 (04/01/16)
Participants:

 Description   

Once SERVER-22338 is finished, we need to do another round of formatting and linting before making "scons lint" fail on JS formatting or linting errors.

We should also enable clang-format for JS formatting by default in these files:

  1. https://github.com/10gen/mongo-enterprise-modules/blob/r3.3.3/.clang-format
  2. https://github.com/mongodb/mongo/blob/r3.3.3/src/mongo/.clang-format
  3. https://github.com/mongodb/mongo/blob/r3.3.3/jstests/.clang-format


 Comments   
Comment by Githook User [ 21/Mar/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-23067 Final round of JS linting and formatting

(cherry picked from commit 617afe421f3ae4c35e8b62589e68beb1c7eb34ed)
Branch: v3.2
https://github.com/10gen/mongo-enterprise-modules/commit/6f803f9ea79c500bbb535bbcf8da9ec9426c01f9

Comment by Githook User [ 21/Mar/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-23067 Final round of JS linting and formatting

(cherry picked from commit 1be713cebbb9411d2977ec9996931a4508252af0)

Conflicts:
jstests/aggregation/bugs/reverseArray.js
jstests/concurrency/fsm_all_simultaneous.js
jstests/core/counta.js
jstests/multiVersion/2_test_launching_cluster.js
jstests/noPassthrough/shard_does_not_hang_on_bad_config_server.js
jstests/readonly/aggregate.js
jstests/readonly/catalog_ops.js
jstests/readonly/geo.js
jstests/readonly/lib/read_only_test.js
jstests/repl/repl5.js
jstests/replsets/replsetprio1.js
jstests/sharding/auth_no_config_primary.js
jstests/sharding/coll_epoch_test1.js
jstests/sharding/merge_chunks_compound_shard_key.js
jstests/sharding/migration_failure.js
jstests/sharding/move_stale_mongos.js
jstests/sharding/startup_with_all_configs_down.js
src/mongo/shell/servers_misc.js
src/mongo/shell/shardingtest.js
Branch: v3.2
https://github.com/mongodb/mongo/commit/3be595d20ee01e453339f5fa389fffaa3dc7f6dc

Comment by Githook User [ 18/Mar/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-23067 Final round of JS linting and formatting
Branch: master
https://github.com/mongodb/mongo/commit/1be713cebbb9411d2977ec9996931a4508252af0

Comment by Githook User [ 18/Mar/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-23067 Final round of JS linting and formatting
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/617afe421f3ae4c35e8b62589e68beb1c7eb34ed

Generated at Thu Feb 08 04:02:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.