[SERVER-23103] Make library dependency graph acyclic Created: 13/Mar/16  Updated: 07/Jun/17  Resolved: 07/Jun/17

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: ADAM Martin (Inactive)
Resolution: Done Votes: 1
Labels: platforms-re-triaged
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-27284 de-dup symbol `mongo::KVHarnessHelper... Closed
depends on SERVER-27361 de-duplicate multiply defined symbol ... Closed
depends on SERVER-27435 Create an evergreen task to check for... Closed
depends on SERVER-27211 de-duplicate multiply defined symbol ... Closed
depends on SERVER-27225 de-duplicate multiply defined symbol ... Closed
depends on SERVER-27233 de-duplicate multiply defined symbol ... Closed
depends on SERVER-27238 de-duplicate multiply defined symbol ... Closed
depends on SERVER-27257 Deduplicate multiply defined symbol `... Closed
depends on SERVER-27287 Deduplicate `_mongoInitializerFunctio... Closed
depends on SERVER-27325 de-duplicate multiply defined symbol ... Closed
depends on SERVER-27326 Dedupe multiply defined symbol `KVDat... Closed
depends on SERVER-27367 Deduplicate multiply defined member f... Closed
depends on SERVER-27384 Deduplicate two `mongo::Command` classes Closed
depends on SERVER-27391 Deduplicate `Command::registerError` ... Closed
depends on SERVER-27415 Deduplicate `Command::execCommand` sy... Closed
depends on SERVER-27912 Stand up an interface to `src/mongo/d... Closed
depends on SERVER-28025 Break `index_access_method`'s depende... Closed
depends on SERVER-28281 Rotate dependency graph "breaks" to m... Closed
depends on SERVER-28552 Stand up interface to `Database` in c... Closed
depends on SERVER-28600 Slice `catalog/collection` class into... Closed
depends on SERVER-28657 Revisit library dependency graph, rep... Closed
depends on SERVER-28805 Slice `catalog/index_catalog` into vt... Closed
depends on SERVER-28811 Resolve satisfiable build graph depen... Closed
depends on SERVER-28832 Slice `catalog/collection_info_cache`... Closed
depends on SERVER-28842 Slice `catalog/database_holder` using... Closed
depends on SERVER-28851 Resolve more cycles from further vtab... Closed
depends on SERVER-28966 Slice `MultiIndexBlock` class with vt... Closed
depends on SERVER-28967 Remove cycle whitelist marks made red... Closed
depends on SERVER-29225 Split off Catalog free functions into... Closed
depends on SERVER-29235 Ripple through resolutions to resolva... Closed
depends on SERVER-29236 Resolve `dbdirectclient` library Closed
depends on SERVER-29252 Update build graph and resolve comple... Closed
depends on SERVER-29253 Merge `catalog/cursor_manager` into l... Closed
depends on SERVER-29305 Make dbdirectclient call into assembl... Closed
is depended on by SERVER-27506 Reduce library graph complexity Closed
is depended on by SERVER-28528 Remove some unnecessary cycle whiteli... Closed
Related
related to SERVER-23298 Refactor ShardingConnectionHook and S... Closed
is related to SERVER-23291 exit_logging.js regex no longer match... Closed
Backwards Compatibility: Fully Compatible
Sprint: Platforms 15 (06/03/16), Platforms 2017-03-06
Participants:
Linked BF Score: 0

 Description   

Currently we have several classes of problems that prevent us from being able to properly express all of the library dependencies in the build system:

  • Circular library dependences (see db/query/query and db/exec/exec).
  • Symbols that lack a unique definition and are defined differently in different contexts (see isMongos, or Command::execCommand).
  • Unexpressed edges, where one library does actually depend on another, but does not declare it.

There are several adverse consequences to this situation, which include:

  • The inability to build under UBSAN, which more aggressively needs symbol information, so fails to link executables that normally link.
  • The inability to easily refactor library dependencies.
  • The inability to link all libraries with -z defs, which makes it impossible to hold the line against making the library graph more tangled.

Here is a list of currently known multiply defined symbols:

multiple definition of `mongo::cmdAuthSchemaUpgrade'
multiple definition of `mongo::cmdCreateRole'
multiple definition of `mongo::cmdCreateUser'
multiple definition of `mongo::cmdDropAllRolesFromDatabase'
multiple definition of `mongo::cmdDropAllUsersFromDatabase'
multiple definition of `mongo::cmdDropRole'
multiple definition of `mongo::cmdDropUser'
multiple definition of `mongo::cmdGrantPrivilegesToRole'
multiple definition of `mongo::cmdGrantRolesToRole'
multiple definition of `mongo::cmdGrantRolesToUser'
multiple definition of `mongo::cmdInvalidateUserCache'
multiple definition of `mongo::cmdMergeAuthzCollections'
multiple definition of `mongo::cmdRevokePrivilegesFromRole'
multiple definition of `mongo::cmdRevokeRolesFromRole'
multiple definition of `mongo::cmdRevokeRolesFromUser'
multiple definition of `mongo::cmdRolesInfo'
multiple definition of `mongo::cmdUpdateRole'
multiple definition of `mongo::cmdUpdateUser'
multiple definition of `mongo::cmdUsersInfo'
multiple definition of `mongo::Command::execCommand(mongo::OperationContext*, mongo::Command*, mongo::rpc::RequestInterface const&, mongo::rpc::ReplyBuilderInterface*)'
multiple definition of `mongo::Command::findCommand(mongo::StringData)'
multiple definition of `mongo::Command::registerError(mongo::OperationContext*, mongo::DBException const&)'
multiple definition of `mongo::createDirectClient(mongo::OperationContext*)'
multiple definition of `mongo::detail::signedCompare(double, double)'
multiple definition of `mongo::detail::signedCompare(double, long)'
multiple definition of `mongo::detail::signedCompare(double, unsigned long)'
multiple definition of `mongo::detail::signedCompare(long, double)'
multiple definition of `mongo::detail::signedCompare(long, long)'
multiple definition of `mongo::detail::signedCompare(long, unsigned long)'
multiple definition of `mongo::detail::signedCompare(unsigned long, double)'
multiple definition of `mongo::detail::signedCompare(unsigned long, long)'
multiple definition of `mongo::detail::signedCompare(unsigned long, unsigned long)'
multiple definition of `mongo::executor::makeCallbackHandle()'
multiple definition of `mongo::haveLocalShardingInfo(mongo::OperationContext*, std::string const&)'
multiple definition of `_mongoInitializerFunction_ForkServer(mongo::InitializerContext*)'
multiple definition of `mongo::isMongos()'
multiple definition of `mongo::KVDatabaseCatalogEntry::getIndex(mongo::OperationContext*, mongo::CollectionCatalogEntry const*, mongo::IndexCatalogEntry*)'
multiple definition of `mongo::KVHarnessHelper::create()'
multiple definition of `mongo::logProcessDetailsForLogRotate()'
multiple definition of `mongo::_mongoInitializerFunction_SetGlobalEnvironment(mongo::InitializerContext*)'
multiple definition of `mongo::myall'
multiple definition of `mongo::newHarnessHelper()'
multiple definition of `mongo::usingAShardConnection(std::string const&)'
multiple definition of `mongo::WiredTigerKVEngine::initRsOplogBackgroundThread(mongo::StringData)'



 Comments   
Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Clean up declaration of db/serveronly
Branch: master
https://github.com/mongodb/mongo/commit/b2e58dc5fa85d96c22adfeb42d3fbed2607ada22

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Remove remaining logic from instance.cpp
Branch: master
https://github.com/mongodb/mongo/commit/8cdf4e80df8fdf28a1057cb50708fab0dd5cd53b

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Add direct dependencies for mongod sources
Branch: master
https://github.com/mongodb/mongo/commit/786f35e9a118d43b3f14b8d173cb3d9973e81477

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move assembleResposne to its own library
Branch: master
https://github.com/mongodb/mongo/commit/a20ff1fe0d639d703314b36031d829c8713c2a91

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move DiagLog to its own library
Branch: master
https://github.com/mongodb/mongo/commit/64f1ca4537d17ea65ceeb05885b48732a314cc02

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move ttl to own library
Branch: master
https://github.com/mongodb/mongo/commit/de76e4a97fb1de1971ba20a25eb9d2683722ee8a

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move storage_init.cpp to own library
Branch: master
https://github.com/mongodb/mongo/commit/25fa51c9438caa37adda1fb7c90548f3032593a8

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Merge sharding connection hook for mongod into sharding library
Branch: master
https://github.com/mongodb/mongo/commit/3caf2a8c1ff6db84cbe20adadb57c3949a253912

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move RepairDatabase to its own library
Branch: master
https://github.com/mongodb/mongo/commit/184b39dd85d625594dc8de5bfa762e254387dfc2

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move read and write concern to own library
Branch: master
https://github.com/mongodb/mongo/commit/049a08af59fbfb3ca5367dced43d66823daeb76f

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move mongod range deleter support to own library
Branch: master
https://github.com/mongodb/mongo/commit/adfb211d0db96d44c88003157fe9ea1a9e0f9e59

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move prefetch to its own library
Branch: master
https://github.com/mongodb/mongo/commit/971f4f6eb011eff58539b49f0301f6d84e1dfa22

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move introspect to its own library
Branch: master
https://github.com/mongodb/mongo/commit/c4c221d934753bbcf39492bd95087ee88d190032

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move index things into own library
Branch: master
https://github.com/mongodb/mongo/commit/81863cf2f2d707ecb282846831593370ef467869

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move CuropMetrics to its own library
Branch: master
https://github.com/mongodb/mongo/commit/f2f0613869fe05ceac7f988f04754cb311537a42

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move Cloner to its own library
Branch: master
https://github.com/mongodb/mongo/commit/175b8deb41fc9212e7184067e2a4f015d24542e9

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move ClientCursor to its own library
Branch: master
https://github.com/mongodb/mongo/commit/bdbe34e1755fef351306b76d34dfcb2b384f91c0

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move Background to its own library
Branch: master
https://github.com/mongodb/mongo/commit/88b4b21054163d0c9f7f50add8093270ed1f63bc

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move OpObserverImpl to own library
Branch: master
https://github.com/mongodb/mongo/commit/060d3af8b26a53e045c81687f14660c8a6851a9f

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Move mongod service context to own library
Branch: master
https://github.com/mongodb/mongo/commit/ebb40747946c7b639b124690c20bf5ad9a7fd1e2

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Complete several libraries
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/1dae85bdbffaf7b5155d80981fb7f6beca536841

Comment by Githook User [ 14/Dec/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Update to adapt to moving assembleResponse to new library
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/a9b1ff41882bdc3e787fdee164106095806f3cd3

Comment by Andrew Morrow (Inactive) [ 29/Nov/16 ]

I just re-ran the multiply defined symbol check, and I find the list to be:

 definition of 'mongo::Command::execCommand(mongo::OperationContext*, mongo::Command*, mongo::rpc::RequestInterface const&, mongo::rpc::ReplyBuilderInterface*)'
- definition of 'mongo::Command::findCommand(mongo::StringData)' -
 definition of 'mongo::Command::registerError(mongo::OperationContext*, mongo::DBException const&)'
- definition of '_mongoInitializerFunction_ForkServer(mongo::InitializerContext*)'-
- definition of 'mongo::isMongos()'-
- definition of 'mongo::KVDatabaseCatalogEntry::getIndex(mongo::OperationContext*, mongo::CollectionCatalogEntry const*, mongo::IndexCatalogEntry*)' -
- definition of 'mongo::KVHarnessHelper::create()'-
- definition of 'mongo::logProcessDetailsForLogRotate()'-
- definition of 'mongo::_mongoInitializerFunction_SetGlobalEnvironment(mongo::InitializerContext*)' -
- definition of 'mongo::myall'-
- definition of 'mongo::newHarnessHelper()' -
- definition of 'mongo::usingAShardConnection(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' -
- definition of 'mongo::WiredTigerKVEngine::initRsOplogBackgroundThread(mongo::StringData)' -

Comment by Githook User [ 12/Jul/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Split several libraries out of db/serveronly
Branch: master
https://github.com/mongodb/mongo/commit/17dcc253c2ea54e204630771eb3868b9f5c27e87

Comment by Andrew Morrow (Inactive) [ 17/Jun/16 ]

After the above slug of commits, we are down to the following list of multiply defined symbols:

 'mongo::Command::execCommand(mongo::OperationContext*, mongo::Command*, mongo::rpc::RequestInterface const&, mongo::rpc::ReplyBuilderInterface*)'
 'mongo::Command::findCommand(mongo::StringData)'
 'mongo::Command::registerError(mongo::OperationContext*, mongo::DBException const&)'
 'mongo::isMongos()'
 'mongo::KVDatabaseCatalogEntry::getIndex(mongo::OperationContext*, mongo::CollectionCatalogEntry const*, mongo::IndexCatalogEntry*)'
 'mongo::KVHarnessHelper::create()'
 'mongo::logProcessDetailsForLogRotate()'
 'mongo::newHarnessHelper()'
 'mongo::usingAShardConnection(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
 'mongo::WiredTigerKVEngine::initRsOplogBackgroundThread(mongo::StringData)'

The above was generated via the following command:

scons CCFLAGS=-fPIC VERBOSE=1 --runtime-hardening=off --ssl --cache --dbg=on --opt=on --implicit-cache --variables-files= CC=/opt/mongodbtoolchain/v2/bin/gcc CXX=/opt/mongodbtoolchain/v2/bin/g++ -j18 all && /opt/mongodbtoolchain/v2/bin/g++ $(find build/cached -type f -name "*.o") -shared -fuse-ld=gold -Wl,--no-allow-multiple-definition -fPIC -o unified 2>&1 | grep "multipl" | awk -F"multiple" '{ print $2 }' | sort | uniq

The list of multiply defined symbols break down into the following logical groups:

  • The Command symbols are multiply defined because the implementation of the Command class needs to vary between mongos and mongod.
  • The isMongos function is used only in the sorter. max.hirschhorn and charlie.swanson have expressed interest in unwinding this.
  • The usingAShardConnection function has only one point of use. kaloian.manassiev and/or schwerin, do you have any thoughts on how we might eliminate it?
  • The logProcessDetailsForLogRotate is tricky, since it is a global function that is invoked from inside the signal handler subsystem. schwerin, do you have any ideas how we might address this?
  • The KVDatabaseCatalogEntry, KVHarnessHelper, newHarnessHelper, and initRsOplobBackgroundThread are all part of storage engine internals and testing. geert.bosch, any ideas?

Overall, we are very close to being able to have unique definitions for all symbols. That is a hard prerequisite to being able to make the dependency graph acyclic.

Comment by Githook User [ 17/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 The unit test crutch has been removed
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/39ea0942320612d87040920e1a193ed4d02f4f99

Comment by Githook User [ 16/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Repair ussert ID collision
Branch: master
https://github.com/mongodb/mongo/commit/da3c28e428615f9f9d18e277ed69b199242ab3ec

Comment by Githook User [ 16/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Don't use pooled scopes in benchrun

Pooled scopes are a database side concept and rely on the
existence of DBDirectClient, which we don't have in the shell.
Branch: master
https://github.com/mongodb/mongo/commit/f81e13cd1a6e8baf585eb0185bdbfcd4f4452d9e

Comment by Githook User [ 16/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Remove the ntservice mock
Branch: master
https://github.com/mongodb/mongo/commit/c541aa74a50c0af55b036b7d3589deaa9b0e21c1

Comment by Githook User [ 16/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Remove clientAndShell as it is now empty
Branch: master
https://github.com/mongodb/mongo/commit/87394d5f68cc1afd75c15c26c4e9ff5bbb23a643

Comment by Githook User [ 16/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Remove the unit test crutch
Branch: master
https://github.com/mongodb/mongo/commit/7d78e7c9aea448c2840deadd58efb20baded72e4

Comment by Githook User [ 16/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Repair some bad includes
Branch: master
https://github.com/mongodb/mongo/commit/ed047465b06a5c7e62154fa93e68b5f2ffe56f5b

Comment by Githook User [ 16/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Refactor access to haveLocalShardingInfo
Branch: master
https://github.com/mongodb/mongo/commit/3ab27a1be85d33f07a4aa9a5e84cfc4f3231ee86

Comment by Githook User [ 16/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Make service contexts responsible for creating DBDirectClients
Branch: master
https://github.com/mongodb/mongo/commit/dc73a4b9567e1ebdb6ba6c9a41a919a0c7c6adf0

Comment by Githook User [ 16/Jun/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Add missing inline keyword
Branch: master
https://github.com/mongodb/mongo/commit/0884bee06018f5f450b431cf6c5ac5eeeab6827a

Comment by Githook User [ 23/Mar/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23291 Update regex per changes in SERVER-23103
Branch: master
https://github.com/mongodb/mongo/commit/619d0066a6e4d5a9684de8f0313c80a8c5c43968

Comment by Githook User [ 22/Mar/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Update for exit handling changes
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/bb8a33169798568fd04460a722ff6c1d24d0082c

Comment by Githook User [ 22/Mar/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Decouple BackgroundJob and SSLManager
Branch: master
https://github.com/mongodb/mongo/commit/8a5eb4206775a9497a44f01e9108743cc3cd25c4

Comment by Githook User [ 22/Mar/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Remove some stale or resolve some trivial incomplete tags
Branch: master
https://github.com/mongodb/mongo/commit/13d736d45f798ed1881bcbad187c3fdf31789f86

Comment by Githook User [ 22/Mar/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Break circularity between optime and bson_extract
Branch: master
https://github.com/mongodb/mongo/commit/efc57ffd9d4912812d1e1f6649aebd7465fd3e38

Comment by Githook User [ 22/Mar/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Make libcommand not depend on libcurop
Branch: master
https://github.com/mongodb/mongo/commit/6877d732e6d5739f9526d89d8e1360c08672eda7

Comment by Githook User [ 22/Mar/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Add some missing libdeps edges
Branch: master
https://github.com/mongodb/mongo/commit/d5dce08c36ab4a928c5345ee18c57327234940f1

Comment by Githook User [ 22/Mar/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23103 Unify exit handling
Branch: master
https://github.com/mongodb/mongo/commit/4d6dd3b4359dc3cc8145beb10e54f84353689351

Generated at Thu Feb 08 04:02:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.