[SERVER-23160] error_propagation.js checks for the wrong error message. Created: 15/Mar/16 Updated: 14/Apr/16 Resolved: 16/Mar/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.3.4 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Benjamin Murphy | Assignee: | Benjamin Murphy |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Sprint: | Query 12 (04/04/16) | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 0 | ||||||||||||
| Description |
|
In the commit that introduced the $type expression (https://github.com/mongodb/mongo/commit/a9d3450f9a40c6ef02b5713c9f0841aa424a327a), typeName output was changed, breaking error_propagation.js, which checks the text of an error message. We should either change the string the error message is checked against, or make the test check the error code instead of message. |
| Comments |
| Comment by Githook User [ 16/Mar/16 ] |
|
Author: {u'username': u'benjaminmurphy', u'name': u'Benjamin Murphy', u'email': u'benjamin_murphy@me.com'}Message: |
| Comment by Dianna Hohensee (Inactive) [ 16/Mar/16 ] |
|
This is where the error message comes from: https://github.com/mongodb/mongo/blob/master/src/mongo/db/pipeline/expression.cpp#L417. error_propagation.js was put in after fixing an error message regression ( |