[SERVER-23163] ReplicationExecutor::onEvent() should signal worker thread when the work is ready Created: 15/Mar/16 Updated: 11/Mar/17 Resolved: 18/Apr/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.13, 3.3.5 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Siyuan Zhou | Assignee: | Siyuan Zhou |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Requested: |
v3.2
|
||||
| Sprint: | Repl 12 (04/01/16), Repl 13 (04/22/16) | ||||
| Participants: | |||||
| Comments |
| Comment by Githook User [ 11/Mar/17 ] |
|
Author: {u'username': u'visualzhou', u'name': u'Siyuan Zhou', u'email': u'siyuan.zhou@mongodb.com'}Message: (cherry picked from commit 09b99e5c6659e60c992288e6b391bd2cb9e409c9) |
| Comment by Siyuan Zhou [ 01/Feb/17 ] |
|
Yeah, the executor rarely becomes empty and the symptom of this bug is probably just delayed works / events. It's more likely to happen in unit tests. |
| Comment by Spencer Brody (Inactive) [ 01/Feb/17 ] |
|
Huh, kind of surprising we don't see this come up more often then. Anyway, backport is approved. |
| Comment by Siyuan Zhou [ 01/Feb/17 ] |
|
It's an real bug that the executor didn't signal its worker sometimes after adding jobs to the work queue. Given that replication executor is used in 3.2, I think this should be backported. |
| Comment by Spencer Brody (Inactive) [ 31/Jan/17 ] |
|
siyuan.zhou, can you comment a bit more on what this fixes? I'm trying to figure out if we should do BACKPORT-162, but I don't really understand the implications of the change. |
| Comment by Githook User [ 12/Apr/16 ] |
|
Author: {u'username': u'visualzhou', u'name': u'Siyuan Zhou', u'email': u'siyuan.zhou@mongodb.com'}Message: |
| Comment by Siyuan Zhou [ 15/Mar/16 ] |
|
milkie, requested backport to 3.2, not sure if we need to backport to 3.0. |