[SERVER-23323] listen_test should join the listening thread on all exit paths Created: 23/Mar/16  Updated: 14/Apr/16  Resolved: 24/Mar/16

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: None
Fix Version/s: 3.3.4

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 0
Labels: bf-test
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Platforms 12 (04/01/16)
Participants:
Linked BF Score: 0

 Description   

If the ASSERT_APPROX_EQUAL in listen_test fails, it throws an assertion failure exception. That leaves the joinable thread 't' unjoined when t's destructor is invoked. That leads to an immediate call to terminate before the message about the failed test is printed.

We need to both join the thread on all paths, and fix up the test so that it isn't flaky.



 Comments   
Comment by Githook User [ 24/Mar/16 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-23323 Make listen_test somewhat more robust
Branch: master
https://github.com/mongodb/mongo/commit/acecea6df3326f6e94063bad2a0f900329f7af4e

Generated at Thu Feb 08 04:03:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.