[SERVER-23369] Run ReadConcern Passthrough tests with all replica set configurations Created: 28/Mar/16  Updated: 06/Dec/22  Resolved: 13/Mar/18

Status: Closed
Project: Core Server
Component/s: Replication, Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Scott Hernandez (Inactive) Assignee: Backlog - Replication Team
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Replication
Participants:

 Description   

Currently the tests only run with a replicaset config of pv1+ writeConcernMajorityJournalDefault:false so that the suites are compatible with ephemeral and noJournal runs:
https://github.com/mongodb/mongo/blob/f88e2487baf7183e022f485ade359761fc62c6c2/buildscripts/resmokeconfig/suites/read_concern_majority_passthrough.yml#L76

Enabled here setting up the replica set:
https://github.com/mongodb/mongo/blob/f88e2487baf7183e022f485ade359761fc62c6c2/buildscripts/resmokelib/testing/fixtures/replicaset.py#L92

We need to change things so that we set this option based on the support provided in the variant/storage-engine, or we run the tests multiple times with different options. Either way, some configurations are not compatible like noJournal/
ephemeral + writeConcernMajorityJournalDefault:true.



 Comments   
Comment by Spencer Brody (Inactive) [ 13/Mar/18 ]

In theory we could run with writeConcernMajorityJournalDefault=false but with journaling on, but I'm not sure there's any real value in testing that configuration.

Comment by Judah Schvimer [ 07/Mar/18 ]

I don't think that will work due to SERVER-32769, which made it fatal to run a replica set with wiredTiger without journaling. I'm fine with "Gone Away" for this ticket in that case.

Comment by Max Hirschhorn [ 07/Mar/18 ]

Andy's changes from cdc7af4 as part of SERVER-27490 and my changes from 35b5b72 as part of SERVER-32522 made it so we'll now WiredTiger with writeConcernMajorityJournalDefault=true and InMemory with writeConcernMajorityJournalDefault=false.

If we add the *read_concern_majority_passthrough tasks to the Linux (No Journal) builder, then we'll end up running WiredTiger with writeConcernMajorityJournalDefault=false. judah.schvimer, spencer, would that be sufficient for what this ticket is trying to achieve? From the Replication team's perspective how valuable is it to have that additional testing?

Generated at Thu Feb 08 04:03:11 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.