[SERVER-23377] _migrateClone can keep on returning the same document Created: 28/Mar/16 Updated: 14/Apr/16 Resolved: 30/Mar/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | 3.3.3 |
| Fix Version/s: | 3.3.4 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Randolph Tan | Assignee: | Kaloian Manassiev |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Sprint: | Sharding 12 (04/01/16) | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 0 | ||||||||
| Description |
|
and can theoretically result in a migration that never ends. The issue is caused by yielding here: Here, we break early and if the iterator didn't move then the erase here: will end up erasing nothing. A potential fix is to move the yield check at top to make sure that the iterator is not equal to the begin iterator when the command added a document to the response buffer (with a check that it is not equal to the begin iterator, otherwise, we can end up with a different problem of not returning any document). |
| Comments |
| Comment by Githook User [ 30/Mar/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Randolph Tan [ 29/Mar/16 ] |
|
schwerin This is a bug introduced by a recent commit in master. |
| Comment by Andy Schwerin [ 28/Mar/16 ] |
|
Is this from the migration refactor on the master branch during 3.3 development, or does it exist in older versions? |