[SERVER-23409] Add tunability to tcmalloc serverStatus detail Created: 29/Mar/16  Updated: 20/Nov/16  Resolved: 24/May/16

Status: Closed
Project: Core Server
Component/s: Diagnostics
Affects Version/s: 3.3.3
Fix Version/s: 3.2.9, 3.3.8

Type: Improvement Priority: Major - P3
Reporter: Kyle Suarez Assignee: Kyle Suarez
Resolution: Done Votes: 0
Labels: code-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Documented
is documented by DOCS-7159 tcmalloc serverStatus section Closed
Related
related to SERVER-23594 Add option to specify TCMalloc statis... Closed
Backwards Compatibility: Fully Compatible
Backport Completed:
Sprint: Integrate+Tuning 15 (06/03/16)
Participants:

 Description   

After SERVER-23069, the size of the TCMalloc section in serverStatus has grown substantially with the addition of per-size class statistics (roughly 10-11 kB). This negatively affects FTDC data retention.

It would be nice to be able to tune the level of detail with which we get TCMalloc statistics; for example,

  • tcmalloc: 1 returns the original level of detail prior to SERVER-23069 without size class information;
  • tcmalloc: 2 includes additional size class information;
  • tcmalloc: 3 includes the TCMalloc `DumpStats` text blob;

and so on. (This behavior would also be backwards-compatible for people already specifying tcmalloc: 1 to serverStatus.)



 Comments   
Comment by Githook User [ 18/Jul/16 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'kyle.suarez@mongodb.com'}

Message: SERVER-23409 tunable verbosity for tcmalloc in serverStatus

(cherry picked from commit c30521d090c27d3ab4f3efaf8494a90ea71c1813)
(cherry picked from commit a3ca8b1a4f33157c8af2fc87ba35f2dc2b28f9ed)
Branch: v3.2
https://github.com/mongodb/mongo/commit/82ead38b6b0df975af2fd2f4cc2f6c309ad58393

Comment by Githook User [ 24/May/16 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'kyle.suarez@mongodb.com'}

Message: SERVER-23409 fix lint
Branch: master
https://github.com/mongodb/mongo/commit/a3ca8b1a4f33157c8af2fc87ba35f2dc2b28f9ed

Comment by Githook User [ 24/May/16 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'kyle.suarez@mongodb.com'}

Message: SERVER-23409 tunable verbosity for tcmalloc in serverStatus
Branch: master
https://github.com/mongodb/mongo/commit/c30521d090c27d3ab4f3efaf8494a90ea71c1813

Comment by Bruce Lucas (Inactive) [ 29/Mar/16 ]

I think it could continue to accept true or false, with the same meaning as 1 and 0.

Comment by Kyle Suarez [ 29/Mar/16 ]

This will probably require new documentation stating that the tcmalloc option strictly requires an integer, along with an explanation of valid levels (if we go this route).

Generated at Thu Feb 08 04:03:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.