[SERVER-23412] Get rid of Command::logIfSlow Created: 29/Mar/16 Updated: 14/Apr/16 Resolved: 30/Mar/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 3.3.4 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Kaloian Manassiev | Assignee: | Kaloian Manassiev |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Sharding 12 (04/01/16) |
| Participants: |
| Description |
|
The Command::logIfSlow method is unnecessary because we do slow command logging at the root of request execution. |
| Comments |
| Comment by Githook User [ 30/Mar/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Kyle Suarez [ 29/Mar/16 ] |
|
Good to know, thanks! |
| Comment by Kaloian Manassiev [ 29/Mar/16 ] |
|
The common place where slow requests are logged is in instance.cpp. In particular, this is the code which logs slow requests. By calling logIfSlow we will double log the slow request. |
| Comment by Kyle Suarez [ 29/Mar/16 ] |
|
Sorry, could you please clarify what "at the root of the request execution" means or where that might be? (In the future, when implementing the operation latency histogram, I had intended it to be done at the same time as the logIfSlow logic.) |