[SERVER-23444] Pessimizing moves break compile on clang 3.7+ (expression_tree.h) Created: 31/Mar/16 Updated: 14/Apr/16 Resolved: 31/Mar/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | 3.3.4 |
| Type: | Bug | Priority: | Blocker - P1 |
| Reporter: | Scott Hernandez (Inactive) | Assignee: | Benjamin Murphy |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Sprint: | Query 12 (04/04/16) | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
Since changing src/mongo/db/matcher/expression_tree.h, we now get errors during compilation, on clang 3.7+.
|
| Comments |
| Comment by Githook User [ 31/Mar/16 ] |
|
Author: {u'username': u'benjaminmurphy', u'name': u'Benjamin Murphy', u'email': u'benjamin_murphy@me.com'}Message: |
| Comment by Scott Hernandez (Inactive) [ 31/Mar/16 ] |
|
We can just return the unique_ptr without a std::move. More reading for clarity: http://stackoverflow.com/questions/25885065/how-can-a-unique-ptr-be-returned-by-value-without-stdmove |