[SERVER-23491] set_majority_read_and_write_concerns.js doesn't work for updates Created: 04/Apr/16  Updated: 18/Nov/16  Resolved: 26/Apr/16

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.2.7, 3.3.6

Type: Bug Priority: Critical - P2
Reporter: Scott Hernandez (Inactive) Assignee: Michael Grundy
Resolution: Done Votes: 0
Labels: test-only
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Duplicate
Related
is related to SERVER-21012 Update read majority passthrough to o... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Completed:
Sprint: TIG 13 (04/22/16), TIG 14 (05/13/16)
Participants:
Linked BF Score: 0

 Description   

The overrides aren't replacing the writeConcern for updates.

Initial testing showed this to an issue for updates which supply a writeConcern, so some code paths might add a writeConcern correctly.



 Comments   
Comment by Githook User [ 10/May/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-23491 set_majority_read_and_write_concerns.js doesn't work for updates

(cherry picked from commit 19d3e69975d32bf8f358aafe4067d578a4bf4440)

Conflicts:
buildscripts/resmokeconfig/suites/read_concern_majority_passthrough.yml
Branch: v3.2
https://github.com/mongodb/mongo/commit/bef3ecb7a957a1efbf96b14828e343584b1a242b

Comment by Githook User [ 26/Apr/16 ]

Author:

{u'username': u'mgrundy', u'name': u'Mike Grundy', u'email': u'michael.grundy@10gen.com'}

Message: SERVER-23491 set_majority_read_and_write_concerns.js doesn't work for updates
Branch: master
https://github.com/mongodb/mongo/commit/19d3e69975d32bf8f358aafe4067d578a4bf4440

Comment by Githook User [ 06/Apr/16 ]

Author:

{u'username': u'IanWhalen', u'name': u'Ian Whalen', u'email': u'ian.whalen@gmail.com'}

Message: SERVER-23491 Temporarily remove update_multi5.js from read_concern_majority_passthrough_WT
Branch: master
https://github.com/mongodb/mongo/commit/874a4a64863bf0138da4b7c880128f60a9b90f33

Comment by Michael Grundy [ 05/Apr/16 ]

ian.whalen Either disable update_multi5.js or revert the change that added the w:1 writeConcern to the update. We're going to change where we override the writeConcern so it's more resilient. Right now if there is no writeConcern passed in then the bulk api will call getWriteConcern (which we have overridden).

Comment by Ian Whalen (Inactive) [ 04/Apr/16 ]

michael.grundy should we start this by disabling update_multi5.js in this suite until you've got a real fix?

Comment by Scott Hernandez (Inactive) [ 04/Apr/16 ]

Example, with logging in the override function to print "processing <cmd>" for all processed commands:

 ----
[js_test:update_multi5] 2016-04-04T09:04:12.396-0400 doing update.
[js_test:update_multi5] 2016-04-04T09:04:12.396-0400 ----
[js_test:update_multi5] 2016-04-04T09:04:12.396-0400 
[js_test:update_multi5] 2016-04-04T09:04:12.396-0400 
[js_test:update_multi5] 2016-04-04T09:04:12.396-0400 
[js_test:update_multi5] 2016-04-04T09:04:12.396-0400 
[js_test:update_multi5] 2016-04-04T09:04:12.397-0400 ----
[js_test:update_multi5] 2016-04-04T09:04:12.397-0400 processing command 'setParameter' :{ "setParameter" : 1, "logComponentVerbosity" : { "verbosity" : 2 } } with options: 0
[js_test:update_multi5] 2016-04-04T09:04:12.397-0400 ----
[js_test:update_multi5] 2016-04-04T09:04:12.397-0400 
[js_test:update_multi5] 2016-04-04T09:04:12.397-0400 
[ReplicaSetFixture:job0:primary] 2016-04-04T09:04:12.397-0400 D COMMAND  [conn11] run command test.$cmd { update: "update_multi5", updates: [ { q: {}, u: { $addToSet: { subscribers: 5.0 } }, multi: true, upsert: false } ], ordered: true, writeConcern: { w: 1.0 } }
[ReplicaSetFixture:job0:primary] 2016-04-04T09:04:12.397-0400 D QUERY    [conn11] Only one plan is available; it will be run but will not be cached. query: {} sort: {} projection: {}, planSummary: COLLSCAN
[js_test:update_multi5] 2016-04-04T09:04:12.397-0400 
[js_test:update_multi5] 2016-04-04T09:04:12.397-0400 
[ReplicaSetFixture:job0:primary] 2016-04-04T09:04:12.397-0400 I WRITE    [conn11] update test.update_multi5 update: { $addToSet: { subscribers: 5.0 } } keysExamined:0 docsExamined:2 nMatched:2 nModified:2 keyUpdates:0 numYields:0 locks:{ Global: { acquireCount: { r: 3, w: 3 } }, Database: { acquireCount: { w: 3 } }, Collection: { acquireCount: { w: 1 } }, Metadata: { acquireCount: { w: 2 } }, oplog: { acquireCount: { w: 2 } } } 0ms
[js_test:update_multi5] 2016-04-04T09:04:12.398-0400 ----
[js_test:update_multi5] 2016-04-04T09:04:12.398-0400 update done: { "nMatched" : 2, "nUpserted" : 0, "nModified" : 2 }
[js_test:update_multi5] 2016-04-04T09:04:12.398-0400 ----

Generated at Thu Feb 08 04:03:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.