[SERVER-23493] Cleanup CollectionMetadata class Created: 04/Apr/16  Updated: 26/Apr/16  Resolved: 07/Apr/16

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.3.5

Type: Improvement Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding 12 (04/01/16), Sharding 13 (04/22/16)
Participants:

 Description   

The CollectionMetadata class exposes methods for obtaining a copy of the current metadata with chunks moved/split and merged. These methods should not be allowed to accept invalid values and should either return StatusWith or fassert, but never return null.



 Comments   
Comment by Githook User [ 05/Apr/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-23493 Cleanup CollectionMetadata cloneSplit and cloneMerge

Get rid of the out parameter and make them use invariant plus a failed
status.
Branch: master
https://github.com/mongodb/mongo/commit/11efcec0aa387b9c8e4f2ce8addd185d515479ea

Comment by Githook User [ 04/Apr/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-23493 Cleanup CollectionMetadata::clonePlusChunk

The clonePlusChunk method is only used for testing purposes, so there is
no need for it to uassert. Add invariands and remove an unnecessary out
parameter.
Branch: master
https://github.com/mongodb/mongo/commit/3ea691f6fea329ee449056c23631610a2c9bd069

Comment by Githook User [ 04/Apr/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: Revert "SERVER-23493 Cleanup CollectionMetadata::clonePlusChunk"

This reverts commit 69e76a1c722dc869e5e49e388298896460a173b8.
Branch: master
https://github.com/mongodb/mongo/commit/d44068507081433dff3eb9619223dc566c661a68

Comment by Githook User [ 04/Apr/16 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-23493 Cleanup CollectionMetadata::clonePlusChunk

The clonePlusChunk method is only used for testing purposes, so there is
no need for it to uassert. Add invariands and remove an unnecessary out
parameter.
Branch: master
https://github.com/mongodb/mongo/commit/69e76a1c722dc869e5e49e388298896460a173b8

Generated at Thu Feb 08 04:03:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.