[SERVER-23494] Remove link dependency of mongod on mongoscore Created: 04/Apr/16 Updated: 25/Jan/17 Resolved: 27/May/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.3.8 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Andy Schwerin |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Sharding 12 (04/01/16), Sharding 13 (04/22/16), Sharding 14 (05/13/16), Sharding 15 (06/03/16) |
| Participants: |
| Description |
|
The Chunk class contains utilities, which the router (mongos) uses for manipulating chunk metadata. It so happens that this class also contains static configuration used by mongod for chunk split decisions. In particular, the Chunk::MaxObjectPerChunk value. Because of this dependency, mongod needs to link everything from mongos, which makes linking slow. In order to fix this, the mongod specific parts should be pulled out of Chunk. |
| Comments |
| Comment by Andy Schwerin [ 27/May/16 ] |
|
kaloian.manassiev, I no longer see any dependency between mongod and mongoscore. I tried the following simple experiments, expecting to see a linking error if the dependency existed: (1) I removed the definition of mongoscore form the SConscript file, and successfully compiled and linked mongod |
| Comment by Githook User [ 25/Apr/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: This is in order to make the mongos egress metadata hook and GLE stats |
| Comment by Githook User [ 19/Apr/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 19/Apr/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Revert " This reverts commit f489fa393f3d878cc2284d1b8d13243099140dff. |
| Comment by Githook User [ 19/Apr/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Also saveGLEStats into sharding_egress_metadata_hook_for_mongos on the way |
| Comment by Githook User [ 06/Apr/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 05/Apr/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: It belongs together with ShardConnection and should not be part of |
| Comment by Githook User [ 05/Apr/16 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |