[SERVER-23546] Collection::requiresIdIndex may be incomplete Created: 05/Apr/16  Updated: 06/Dec/22  Resolved: 10/Jun/19

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: 3.3.4
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: Robert Guo (Inactive) Assignee: Backlog - Storage Execution Team
Resolution: Done Votes: 0
Labels: nyc
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-31216 Mark internal collections in metadata... Closed
Assigned Teams:
Storage Execution
Participants:

 Description   

We need to audit if this function is missing collections that shouldn't require an Id index. Possible candidates are the users and roles collection.



 Comments   
Comment by Eric Milkie [ 10/Jun/19 ]

I believe system.users and system.roles need an _id index, currently.

Comment by Robert Guo (Inactive) [ 25/Apr/16 ]

ian.whalen, this ticket stemmed from a CR with scotthernandez where we were looking at code adjacent to this function and saw this function may be missing some things.

I did a quick check of the authorization_manager code and it looks like the system.users and system.roles collections don't need the _id index, so they should be added to this function.

I'll move this to needs triage for now. The current behavior is not causing any problems and we don't need to fix it in the 3.3 cycle.

edit: oops I misremembered, it was a CR with Scott, not Geert.

Comment by Ian Whalen (Inactive) [ 25/Apr/16 ]

robert.guo can you explain why you think this might be incomplete? Is this just a feeling or did you run into something in particular? Otherwise we're tempted to close as Won't Fix.

Generated at Thu Feb 08 04:03:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.