[SERVER-23671] build fails if using system tcmalloc but third party valgrind Created: 13/Apr/16  Updated: 26/Apr/16  Resolved: 13/Apr/16

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: 3.3.4
Fix Version/s: 3.3.5

Type: Bug Priority: Major - P3
Reporter: Michael Hudson-Doyle Assignee: Mark Benvenuto
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Steps To Reproduce:

scons --use-system-tcmalloc should do it, I think.

Participants:

 Description   

As you can see here https://launchpadlibrarian.net/251967168/buildlog_ubuntu-xenial-amd64.mongodb_1%3A3.3.3-0ubuntu1_BUILDING.txt.gz a build with --use-system-tcmalloc failed because tcmalloc_server_status_section.cpp could not find valgrind.h. This is a logic failure in src/mongo/utils/SConscript: it only calls tcmspEnv.InjectThirdPartyIncludePaths('valgrind') if using the third party tcmalloc, not if using the third parth valgrind.

I'll send a PR with a fix in a moment.



 Comments   
Comment by Githook User [ 13/Apr/16 ]

Author:

{u'username': u'mwhudson', u'name': u'Michael Hudson-Doyle', u'email': u'michael.hudson@canonical.com'}

Message: SERVER-23671 fix build failure with --use-system-tcmalloc but not --use-system-valgrind

Closes #1077

Signed-off-by: Mark Benvenuto <mark.benvenuto@mongodb.com>
Branch: master
https://github.com/mongodb/mongo/commit/da9f7847b1895410bd05e147dfbf88d631479e26

Generated at Thu Feb 08 04:04:08 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.