[SERVER-23728] Enable the no-unused-expressions ESLint rule to find dead code Created: 14/Apr/16 Updated: 06/Dec/17 Resolved: 11/Apr/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.6 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Kamran K. | Assignee: | Eddie Louie |
| Resolution: | Done | Votes: | 1 |
| Labels: | bkp, tig-eslint | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Backport Requested: |
v3.2
|
||||||||||||||||||||
| Sprint: | TIG 2017-04-17 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||
| Description |
|
The no-unused-expressions rule can catch bugs like
|
| Comments |
| Comment by Eddie Louie [ 11/Apr/17 ] |
|
The deadlock uncovered in jstests/core/eval_wait_for_read_write_concern.js will be tracked with |
| Comment by Max Hirschhorn [ 07/Apr/17 ] |
eddie.louie, this ticket cannot be resolved with the jstests/core/eval_wait_for_read_write_concern.js test commented out. The purpose of this ticket was not only to enable the no-unused-expressions lint rule, but also to ensure that any affected test cases get enabled. We should determine why the test is hanging. For example, I wonder if it shouldn't be running as part of the jstests/core/ directory and that's causing a problem. If so, then it could be moved to the jstests/replsets/ directory and modified to start its own ReplSetTest. |
| Comment by Eddie Louie [ 06/Apr/17 ] |
|
Fixed two new lint errors as part of this ticket. |
| Comment by Githook User [ 06/Apr/17 ] |
|
Author: {u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}Message: |
| Comment by Githook User [ 06/Apr/17 ] |
|
Author: {u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}Message: |
| Comment by Githook User [ 05/Apr/17 ] |
|
Author: {u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}Message: |